-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address deprecations of StaticSingleThreadedExecutor and realtime_tools/thread_priority.hpp #3139
Conversation
@TSNoble this is the next failure blocking your PR |
Gah there is another deprecation warning in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3139 +/- ##
=========================================
+ Coverage 0 45.63% +45.63%
=========================================
Files 0 482 +482
Lines 0 40432 +40432
=========================================
+ Hits 0 18449 +18449
- Misses 0 21983 +21983 ☔ View full report in Codecov by Sentry. |
And now this stops working with Humble. So I guess this is it. |
Is it just the include file name changed? Does the new filename not exist in humble at all? If so, we could maybe keep humble support for a little longer by doing the "if this file exists, include it, otherwise the old file name" like we've done for the urdf.h/hpp If we do that, we should probably open a ticket to track the stuff that should be cleaned up after we finally do stop supporting humble on main |
Yeah, good idea. I'll tack that on. |
961edeb
to
556fc8e
Compare
Okay now I see why you were worried about adding warnings to our own headers 😅 Thanks for sorting out my PR and taking a look at this 👍 |
Description
We just got hit with a Rolling deprecation warning :)
ros2/rclcpp#2598
It begs the question: We may need to cut the Jazzy release first by force-merging #3113 and #3140 before putting this in...
Checklist