Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecations of StaticSingleThreadedExecutor and realtime_tools/thread_priority.hpp #3139

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Nov 29, 2024

Description

We just got hit with a Rolling deprecation warning :)
ros2/rclcpp#2598

It begs the question: We may need to cut the Jazzy release first by force-merging #3113 and #3140 before putting this in...

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass requested a review from sjahr November 29, 2024 13:31
@sea-bass
Copy link
Contributor Author

@TSNoble this is the next failure blocking your PR

@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 29, 2024

Gah there is another deprecation warning in realtime_tools. Brutal. I will include it too.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.63%. Comparing base (397843c) to head (ef0c815).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3139       +/-   ##
=========================================
+ Coverage      0   45.63%   +45.63%     
=========================================
  Files         0      482      +482     
  Lines         0    40432    +40432     
=========================================
+ Hits          0    18449    +18449     
- Misses        0    21983    +21983     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass changed the title Switch StaticSingleThreadedExecutor to SingleThreadedExecutor Address deprecations of StaticSingleThreadedExecutor and realtime_tools/thread_priority.hpp Nov 29, 2024
@sea-bass
Copy link
Contributor Author

Gah there is another deprecation warning in realtime_tools. Brutal. I will include it too.

And now this stops working with Humble. So I guess this is it.

@mikeferguson
Copy link
Contributor

And now this stops working with Humble. So I guess this is it.

Is it just the include file name changed? Does the new filename not exist in humble at all? If so, we could maybe keep humble support for a little longer by doing the "if this file exists, include it, otherwise the old file name" like we've done for the urdf.h/hpp

If we do that, we should probably open a ticket to track the stuff that should be cleaned up after we finally do stop supporting humble on main

@sea-bass
Copy link
Contributor Author

Is it just the include file name changed? Does the new filename not exist in humble at all? If so, we could maybe keep humble support for a little longer by doing the "if this file exists, include it, otherwise the old file name" like we've done for the urdf.h/hpp

Yeah, good idea. I'll tack that on.

@sea-bass sea-bass force-pushed the remove-static-single-threaded-executor branch from 961edeb to 556fc8e Compare November 29, 2024 15:37
@TSNoble
Copy link
Contributor

TSNoble commented Nov 29, 2024

Okay now I see why you were worried about adding warnings to our own headers 😅

Thanks for sorting out my PR and taking a look at this 👍

@sea-bass sea-bass added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit b781196 Nov 29, 2024
12 of 13 checks passed
@sea-bass sea-bass deleted the remove-static-single-threaded-executor branch November 29, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants