(moveit_py) Allow editing allowed collision matrix in python + fix get_entry function #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
- Coverage 50.89% 50.50% -0.38%
==========================================
Files 388 387 -1
Lines 32245 32083 -162
==========================================
- Hits 16408 16201 -207
- Misses 15837 15882 +45 ☔ View full report in Codecov by Sentry. |
sjahr
approved these changes
Nov 27, 2023
| getEntry(const std::shared_ptr<collision_detection::AllowedCollisionMatrix>& acm, const std::string& name1, | ||
| const std::string& name2) | ||
| // TODO: Create a custom typecaster/revise the current implementation to return std::pair<bool, | ||
| // collision_detection::AllowedCollision::Type> |
There was a problem hiding this comment.
I like that, can you open an issue for that it is better tracked?
sjahr
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow editing allowed collision matrix in python + fix get_entry function
Description
Added a setter + changed from move to reference_internal to allow changes when using inside of a context.
Also added some changes to allow the call of the get_entry function. Currently there is no custom typecaster for collision_detection::AllowedCollision::Type. Added a basic str return for now.
Checklist