Mothership displays correct user title/honorary if updated on the front-end. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamyeats
force-pushed
the
user-titles
branch
from
dd552b1 to
5cd108d
Compare
| // prefix, if available. for example, if the mothership locale is `en_GB`, we load | ||
| // the collection of titles for `en` | ||
| $locale = explode("_", $this->_container['locale']->getId())[0]; | ||
| $titles = $this->_container['cfg']->titles->{$locale}; |
There was a problem hiding this comment.
The values are they keys of the array in Symfony form select boxes, so we need to do something like array_combine($titles, $titles) to align the keys with the values, so that it aligns with the database
There was a problem hiding this comment.
Actually, scratch that, reverse it. We should call the title.list service here
| * | ||
| * @param UserEvent $event | ||
| */ | ||
| public function cleanupSession(UserEvent $event) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88.