Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cluster errors from NetworkError to UserError #1586

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Change cluster errors from NetworkError to UserError #1586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7eeae6
Change cluster errors to user errors
irenedea Oct 11, 2024
9a16876
Merge branch 'main' into usererror
irenedea Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llmfoundry/utils/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,15 +310,15 @@ def __init__(self, input: dict) -> None:


## Convert Delta to JSON exceptions
class ClusterDoesNotExistError(NetworkError):
class ClusterDoesNotExistError(UserError):
"""Error thrown when the cluster does not exist."""

def __init__(self, cluster_id: str) -> None:
message = f'Cluster with id {cluster_id} does not exist. Check cluster id and try again!'
super().__init__(message, cluster_id=cluster_id)


class ClusterInvalidAccessMode(NetworkError):
class ClusterInvalidAccessMode(UserError):
"""Error thrown when the cluster does not exist."""

def __init__(self, cluster_id: str, access_mode: str) -> None:
Expand Down
Loading