Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cluster errors from NetworkError to UserError #1586

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

irenedea
Copy link
Contributor

These should be considered UserErrors

@irenedea irenedea requested a review from a team as a code owner October 11, 2024 17:40
@b-chu b-chu self-requested a review October 11, 2024 17:45
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@irenedea irenedea enabled auto-merge (squash) October 11, 2024 17:46
Copy link
Contributor

@jjanezhang jjanezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@irenedea irenedea merged commit aad13c4 into mosaicml:main Oct 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants