Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): add metrics to count the number of builds #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sylvain-reynaud
Copy link

Closes #16

Ready to be reviewed !

@sylvain-reynaud sylvain-reynaud added enhancement New feature or request minor labels May 13, 2023
@sylvain-reynaud sylvain-reynaud linked an issue May 13, 2023 that may be closed by this pull request
Copy link
Member

@thomasgouveia thomasgouveia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sylvain-reynaud, thanks for the PR ! The idea is here, but you're wrong on the component.

registry and controller are two separated components. I've added in #13 the ability to the controller only to expose metrics. To work properly, you need to add a metrics server to the registry also. You can refer to this commit to learn how to do this.

Also, I prefer to have a dedicated package telemetry for each components. As we don't really know if the registry will be shipped with future release of Morty right now, It will be more easier to clean up files if we remove it.

To wrap up, what you need to change in your PR :

  • Add a metrics server to the registry
  • Add a telemetry package into the registry folder (and the code in it for sure)
  • Update the configuration of the registry so we can pass a custom port for the metrics server

Feel free to ask questions if you need more details!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics to count the number of builds
2 participants