Add metrics instrumentation to Morty #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Provide convenience method to create an HTTP server to expose metrics on `/metrics` of the given address. Signed-off-by: thomasgouveia <[email protected]>
thomasgouveia
force-pushed
the
f-add-metrics
branch
2 times, most recently
from
2c12591 to
1509663
Compare
alexandrebrg
previously approved these changes
May 2, 2023
contrib/grafana/morty-dashboard.json
Outdated
There was a problem hiding this comment.
Along the current docker-compose you could give an extension with a grafana dashboard and monitoring capabilities.
There was a problem hiding this comment.
Will be done through another PR, I hope someone will do it !
- Added metrics to controller component to (Histogram and counter) for function invocations etc. - Configurable port for metrics server Signed-off-by: thomasgouveia <[email protected]>
…12) Signed-off-by: thomasgouveia <[email protected]>
thomasgouveia
force-pushed
the
f-add-metrics
branch
from
1509663 to
9db1439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following improvements :
pkg/telemetryto easily create metrics HTTP server. This module will be improved in the future to provide common methods to add metrics data to our components.controllercomponent to create telemetry data for function invocationsCloses #12