Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(accrued-interests): add interests library #171

Merged
merged 34 commits into from
Aug 17, 2023
Merged

feat(accrued-interests): add interests library #171

merged 34 commits into from
Aug 17, 2023

Conversation

Rubilmax
Copy link
Collaborator

pakim249CAL
pakim249CAL reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@pakim249CAL pakim249CAL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A blue storage slots lib is a great combination with extsload. I think this can be part of the underlying PR.

@Rubilmax
Copy link
Collaborator Author

A blue storage slots lib is a great combination with extsload. I think this can be part of the underlying PR.

I agree it could but at the same time:

  • it's already separate
  • it's made to enable calculating accrued interests specifically

Given that separating PR can help separating contexts, let's keep it like this so we have discussions separate!

Base automatically changed from refactor/extsload to main July 25, 2023 21:49
@Rubilmax Rubilmax mentioned this pull request Jul 26, 2023
Merged
@Rubilmax Rubilmax self-assigned this Jul 31, 2023
@Rubilmax Rubilmax mentioned this pull request Aug 3, 2023
Closed
MathisGD
MathisGD reviewed Aug 6, 2023
View reviewed changes
src/libraries/BlueLib.sol Outdated Show resolved Hide resolved
src/libraries/BlueLib.sol Outdated Show resolved Hide resolved
@Rubilmax Rubilmax marked this pull request as ready for review August 7, 2023 07:36
@Rubilmax Rubilmax mentioned this pull request Aug 7, 2023
Closed
MerlinEgalite
MerlinEgalite requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ease review of this PR: documentation of how to compute storage slot.

I think we should test this library.

src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
src/libraries/BlueLib.sol Outdated Show resolved Hide resolved
src/libraries/BlueLib.sol Outdated Show resolved Hide resolved
src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
src/libraries/BlueStorageSlots.sol Outdated Show resolved Hide resolved
@Rubilmax Rubilmax requested a review from MerlinEgalite August 7, 2023 08:55
MerlinEgalite
MerlinEgalite previously approved these changes Aug 11, 2023
View reviewed changes
@Rubilmax Rubilmax marked this pull request as draft August 11, 2023 07:30
@MathisGD MathisGD dismissed MerlinEgalite’s stale review August 13, 2023 12:30

The merge-base changed after approval.

MathisGD
MathisGD requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@MathisGD MathisGD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests on everything added before merging into main from now

Jean-Grimal
Jean-Grimal previously approved these changes Aug 17, 2023
View reviewed changes
MathisGD
MathisGD reviewed Aug 17, 2023
View reviewed changes
src/libraries/periphery/MorphoStorageLib.sol Outdated Show resolved Hide resolved
src/libraries/periphery/MorphoLib.sol Outdated Show resolved Hide resolved
src/libraries/periphery/MorphoStorageLib.sol Outdated Show resolved Hide resolved
test/forge/periphery/MorphoStorageLib.t.sol Outdated Show resolved Hide resolved
@MerlinEgalite @MathisGD
docs: apply suggestion
f9a46f4 
Co-authored-by: MathisGD <[email protected]>
Signed-off-by: Merlin Egalite <[email protected]>
MathisGD
MathisGD previously approved these changes Aug 17, 2023
View reviewed changes
pakim249CAL
pakim249CAL previously approved these changes Aug 17, 2023
View reviewed changes
@QGarchery QGarchery mentioned this pull request Aug 17, 2023
Closed
QGarchery
QGarchery requested changes Aug 17, 2023
View reviewed changes
src/libraries/periphery/MorphoLib.sol Outdated Show resolved Hide resolved
src/libraries/periphery/MorphoLib.sol Outdated Show resolved Hide resolved
src/libraries/periphery/MorphoStorageLib.sol Outdated Show resolved Hide resolved
src/libraries/periphery/MorphoStorageLib.sol Outdated Show resolved Hide resolved
test/forge/periphery/MorphoStorageLib.t.sol Outdated Show resolved Hide resolved
test/forge/periphery/MorphoStorageLib.t.sol Outdated Show resolved Hide resolved
@MerlinEgalite MerlinEgalite dismissed stale reviews from pakim249CAL and MathisGD via cc78aed August 17, 2023 19:22
@MathisGD MathisGD merged commit de37c00 into main Aug 17, 2023
@MathisGD MathisGD deleted the feat/accrued-interests branch August 17, 2023 20:26
@MathisGD MathisGD mentioned this pull request Aug 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QGarchery QGarchery QGarchery approved these changes

@MathisGD MathisGD MathisGD approved these changes

@MerlinEgalite MerlinEgalite Awaiting requested review from MerlinEgalite

@makcandrov makcandrov Awaiting requested review from makcandrov

@Jean-Grimal Jean-Grimal Awaiting requested review from Jean-Grimal

@pakim249CAL pakim249CAL Awaiting requested review from pakim249CAL

Assignees

@MerlinEgalite MerlinEgalite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make accrueInterests public ?
7 participants
@Rubilmax @QGarchery @MerlinEgalite @pakim249CAL @MathisGD @Jean-Grimal @makcandrov