Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

transfers: delete ACH file when a transfer is deleted #39

Merged

Conversation

adamdecaf
Copy link
Member

We should delete the file to clean out space for other files.

screen shot 2018-12-12 at 9 56 09 am

Issue: https://github.com/moov-io/api/issues/56

ach := achclient.New(userId, logger)

for i := range requests {
id := nextID()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this fixes a bug where multiple transfers would have been created with the same ID.

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #39 into master will decrease coverage by 3.68%.
The diff coverage is 41.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   38.01%   34.32%   -3.69%     
==========================================
  Files          14       14              
  Lines        1710     2214     +504     
==========================================
+ Hits          650      760     +110     
- Misses        904     1293     +389     
- Partials      156      161       +5
Impacted Files Coverage Δ
database.go 36.66% <ø> (-3.34%) ⬇️
transfers.go 29.37% <35.13%> (-4.64%) ⬇️
pkg/achclient/client.go 59.09% <50%> (-4.43%) ⬇️
pkg/achclient/files.go 18.18% <57.14%> (+1.96%) ⬆️
microDeposits.go 42.24% <0%> (-6.68%) ⬇️
common.go 68.42% <0%> (-5.43%) ⬇️
depositories.go 35.61% <0%> (-5.2%) ⬇️
events.go 37.71% <0%> (-4.04%) ⬇️
originators.go 31.93% <0%> (-3.78%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa9030f...250bae8. Read the comment docs.

@adamdecaf adamdecaf merged commit b41b3b7 into moov-io:master Dec 14, 2018
@adamdecaf adamdecaf deleted the delete-ach-file-on-transfer-delete branch December 14, 2018 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants