Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: record ach_files_deleted metric #408

Merged
merged 2 commits into from
Dec 14, 2018

Conversation

adamdecaf
Copy link
Member

@adamdecaf adamdecaf commented Dec 14, 2018

Realized we didn't have this when working on moov-io/paygate#39

@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #408 into master will decrease coverage by 0.7%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #408      +/-   ##
=========================================
- Coverage    85.5%   84.8%   -0.71%     
=========================================
  Files         109     109              
  Lines        6817    8870    +2053     
=========================================
+ Hits         5829    7522    +1693     
- Misses        693    1053     +360     
  Partials      295     295
Impacted Files Coverage Δ
server/files.go 1.29% <0%> (-0.31%) ⬇️
test/ach-adv-read/main.go 55.55% <0%> (-8.09%) ⬇️
test/ach-axt-read/main.go 57.14% <0%> (-8.08%) ⬇️
test/ach-ccd-read/main.go 57.14% <0%> (-8.08%) ⬇️
test/ach-iat-read/main.go 60% <0%> (-8%) ⬇️
test/ach-trc-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-trx-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-xck-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-web-read/main.go 65.71% <0%> (-7.62%) ⬇️
test/ach-shr-read/main.go 45.45% <0%> (-7.49%) ⬇️
... and 96 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b8ad7...0e742ab. Read the comment docs.

@bkmoovio bkmoovio self-requested a review December 14, 2018 04:53
@adamdecaf adamdecaf merged commit 56d9abb into moov-io:master Dec 14, 2018
@adamdecaf adamdecaf deleted the ach-files-deleted-metric branch December 14, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants