Add const values for batch header.service class code #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constant values for ServiceClassCode
DebitsOnly
CreditsOnly
MixedDebitsandCredits
AutomatedAccountingAdvices
Update Comments
CreditsOnly
Constants for ServiceClassCode
Allow only credits, so error should be returned for DebitsOnly
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 85.17% 85.17%
=======================================
Files 107 107
Lines 6785 6785
=======================================
Hits 5779 5779
Misses 723 723
Partials 283 283
Continue to review full report at Codecov.
|
Update text
wadearnold
approved these changes
Dec 6, 2018
advBatchControl.go
Outdated
| // ServiceClassCode ACH Mixed Debits and Credits ‘200’ | ||
| // ACH Credits Only ‘220’ | ||
| // ACH Debits Only ‘225' | ||
| // Constant AutomatedAccountingAdvices: 280 |
There was a problem hiding this comment.
Should this be commented out?
There was a problem hiding this comment.
since this in adv control, I'll have it be this
// This should be the same as BatchHeader ServiceClassCode for ADV: AutomatedAccountingAdvices.
advBatchControl.go
Outdated
| @@ -60,7 +58,8 @@ func (bc *ADVBatchControl) Parse(record string) { | |||
|
|
|||
| // 1-1 Always "8" | |||
| bc.recordType = "8" | |||
| // 2-4 This is the same as the "Service code" field in previous Batch Header Record | |||
| // 2-4 This is the same as the "Service code" field in previous Batch Header Record - | |||
| // AutomatedAccountingAdvices: 280 | |||
There was a problem hiding this comment.
Does this comment need to be here? Not sure what it tells me.
There was a problem hiding this comment.
Ok I'll remove. No problem!
| @@ -49,12 +49,12 @@ func BenchmarkMockADVBatchControl(b *testing.B) { | |||
|
|
|||
| // TestParseADVBatchControl parses a known Batch ControlRecord string. | |||
| func testParseADVBatchControl(t testing.TB) { | |||
| var line = "822500000100053200010000000000000001050000000000000000000000T-BANK 076401250000001" | |||
| var line = "828000000100053200010000000000000001050000000000000000000000T-BANK 076401250000001" | |||
GoDoc update
Code Comment Updates
bkmoovio
deleted the
Add-const-values-for-BatchHeader.ServiceClassCode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#391