Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const values for BatchHeader.ServiceClassCode and BatchControl.ServiceClassCode #391

Closed
bkmoovio opened this issue Dec 4, 2018 · 0 comments

Comments

@bkmoovio
Copy link
Contributor

bkmoovio commented Dec 4, 2018

We have a fair amount of hard-coded values, which aren't that friendly for developers. If we provide names it should help to understand them.

Example: BatchHeader.ServiceClassCode: 200, 220, 225, 280

Identifies the general classification of dollar entries to be exchanged (i.e. debit and/or credit entries)
–200 ACH Entries Mixed Debits and Credits
–220 ACH Credits Only
–225 ACH Debits Only
–280 ACH Automated Accounting Advice

Create developer friendly meaningful constants for these values and modify the code to reference the constants.

@bkmoovio bkmoovio changed the title Add const values for Service Class Code Add const values for BatchHeader.ServiceClassCode and BatchControl.ServiceClassCode Dec 4, 2018
@bkmoovio bkmoovio self-assigned this Dec 4, 2018
@bkmoovio bkmoovio closed this as completed Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant