Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/http: Add a better example for creating a File over HTTP #390

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

adamdecaf
Copy link
Member

Issue: #380

@adamdecaf adamdecaf force-pushed the better-http-example branch from 4e5ed25 to da280f4 Compare December 4, 2018 18:25
@codecov-io
Copy link

codecov-io commented Dec 4, 2018

Codecov Report

Merging #390 into master will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   85.41%   84.94%   -0.48%     
==========================================
  Files         107      107              
  Lines        6774     8793    +2019     
==========================================
+ Hits         5786     7469    +1683     
- Misses        712     1048     +336     
  Partials      276      276
Impacted Files Coverage Δ
test/ach-adv-read/main.go 55.55% <0%> (-8.09%) ⬇️
test/ach-axt-read/main.go 57.14% <0%> (-8.08%) ⬇️
test/ach-ccd-read/main.go 57.14% <0%> (-8.08%) ⬇️
test/ach-iat-read/main.go 60% <0%> (-8%) ⬇️
test/ach-trc-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-trx-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-xck-read/main.go 47.82% <0%> (-7.73%) ⬇️
test/ach-web-read/main.go 65.71% <0%> (-7.62%) ⬇️
test/ach-shr-read/main.go 45.45% <0%> (-7.49%) ⬇️
test/ach-pop-read/main.go 45.45% <0%> (-7.49%) ⬇️
... and 93 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e47e36...da280f4. Read the comment docs.

@bkmoovio bkmoovio self-requested a review December 4, 2018 23:58
@adamdecaf adamdecaf merged commit 8cf26d2 into moov-io:master Dec 5, 2018
@adamdecaf adamdecaf deleted the better-http-example branch December 5, 2018 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants