Add Dynamic Fee support for Moonbeam #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
added
B5-clientnoteworthy
notlesh
commented
Mar 16, 2023
librelois
approved these changes
Apr 3, 2023
tgmichel
reviewed
Apr 11, 2023
tgmichel
approved these changes
Apr 11, 2023
notlesh
commented
Apr 11, 2023
Comment on lines
+1256
to
+1262
| assert_eq!( | ||
| TransactionPaymentAsGasPrice::min_gas_price(), | ||
| ( | ||
| 125_000_000_000u128.into(), | ||
| Weight::from_ref_time(25_000_000u64) | ||
| ) | ||
| ); |
There was a problem hiding this comment.
@tgmichel this should address your earlier comment. It is indeed 125 gwei, but this should be in line with other runtimes when you take the SUPPLY_FACTOR into account.
Does 125 gwei still seem unreasonable?
girazoki
approved these changes
Apr 12, 2023
notlesh
added
D1-audited👍
imstar15
pushed a commit
to AvaProtocol/moonbeam
that referenced
this pull request
May 16, 2023
* Initial mods for dynamic fee on moonbeam * Update tests to use increase fee * Bump gas price in test * Comment out failing test (temporarily) * fmt * Some actually VALID_ETH_TX bytes! * Remove unused import * Add multiplier tests * Enabled dynamic fees smoketest for MB --------- Co-authored-by: timbrinded <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The final quest in the epic journey to bring dynamic fees to Moonbeam. ⚔️ 🐉
Previously: #2078 (Moonriver) and #1765 (Moonbase). See the latter for more context on the R&D that went into this.
Briefly: this uses
pallet-transaction-payment's fee multiplier as a basis for anEIP-1559 gas price, aligning both Substrate-based and Ethereum-based fees to use a similar congestion-based dynamic fee.moonbeamruntime only100 gweigas price replaced with dynamic fee125 gweimoonbaseandmoonriver)TODO: