Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dynamic Fee support for Moonriver #2078

Merged
merged 11 commits into from
Feb 16, 2023
Merged

Add Dynamic Fee support for Moonriver #2078

merged 11 commits into from
Feb 16, 2023

Conversation

notlesh
Copy link
Contributor

@notlesh notlesh commented Feb 7, 2023 •
edited
Loading

What does it do?

Rolls the Dynamic Fee changes introduced in #1765 to Moonriver.

⚠️ Breaking Changes ⚠️

  • All changes are moonriver only
  • Fixed 1 gwei gas price replaced with dynamic fee
  • Minimum multiplier set to a gas price of 1.25 gwei
  • Algorithm responsiveness tuned to double/halve in 1 hour (same as moonbase)

TODO:

  • Add tests
  • Perform fork test
  • Ensure minimum is set appropriately
  • Adjust default (genesis) fee
  • Adjust/re-evaluate block fullness target

@notlesh notlesh added B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited breaking Needs to be mentioned in breaking changes labels Feb 7, 2023
@notlesh notlesh added the A0-pleasereview Pull request needs code review. label Feb 15, 2023
@notlesh notlesh merged commit d205cde into master Feb 16, 2023
@notlesh notlesh deleted the notlesh-dynamic-fee-moonriver branch February 16, 2023 15:48
@notlesh notlesh added D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels Feb 22, 2023
@crystalin crystalin changed the title Dynamic Fee @ Moonriver Add Dynamic Fee support for Moonriver Feb 22, 2023
@notlesh notlesh mentioned this pull request Mar 16, 2023
Merged
5 tasks
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@notlesh @imstar15
Dynamic Fee @ Moonriver (moonbeam-foundation#2078)
eb42845 
* Initial mods for dynamic fee on moonriver

* Amplify AdjustmentVariable

* Fix (and add) moonriver fee tests

* Replace txn blobs with higher fees paid

* fmt

* Adjust moonriver's initial fee, not moonbeam's

* Test min as base_fee

* Add attempt at executeProposalWithCouncil

* Revert "Add attempt at executeProposalWithCouncil"

This reverts commit d128e3c.

* Reduce min multiplier by factor of 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbrinded timbrinded timbrinded left review comments

@librelois librelois librelois approved these changes

Assignees
No one assigned
Labels
A0-pleasereview Pull request needs code review. B5-clientnoteworthy Changes should be mentioned in any downstream projects' release notes B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D1-audited👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@notlesh @librelois @timbrinded