Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix workflow check features #1970

Merged
merged 1 commit into from
Nov 28, 2022
Merged

fix workflow check features #1970

merged 1 commit into from
Nov 28, 2022

Conversation

librelois
Copy link
Collaborator

What does it do?

Add protobuf-compiler to the github runner (now required by libp2p).

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Nov 28, 2022
@librelois librelois requested a review from crystalin November 28, 2022 14:37
@librelois librelois merged commit 6febfea into master Nov 28, 2022
@librelois librelois deleted the elois-fix-workflow-check-features branch November 28, 2022 15:01
@crystalin
Copy link
Collaborator

@librelois I don't think we want this to be part of the CI but to be a requirement of the runner. Not sure
@mario-purestake what's your opinion ?

@librelois
Copy link
Collaborator Author

librelois commented Nov 28, 2022 •
edited
Loading

but to be a requirement of the runner

We can't add a prerequisite to the github runner, we can eventually switch to our own runner, but I think it's a bad idea, I prefer to reserve our runners for jobs that need a short execution time (like validation of a PR).

@mario-sangar
Copy link
Contributor

This is running in GitHub machines, not ours, so I agree with @librelois on that we can't add it to the runner itself. We can go with the package that apt-get installs for us, or we can choose more specifically with the package from GitHub. We can use an action for it, for example: https://github.com/marketplace/actions/setup-protoc

crystalin pushed a commit that referenced this pull request Nov 28, 2022
@nbaztec @4meta5
@boundless-forest @timbrinded @librelois @koushiro @girazoki @nanocryk
Typescript api 2000 (#1973)
6bbb022 
* fix staking benchmark tests (#1951)

* remove reward for delegator warn logs (#1895)

* Add once (#1857)

* Added tests for standard eth RPC methods (#1949)

* Added standard eth RPC tests

* reduced line length

* Added testskip for FullFilter pool

* bump client and runtime versions (#1910)

* Fix CI for external pr (#1963)

* remove useless job docker-parachain

* fix if condition for exterrnal PRs

solution find here: https://github.com/orgs/community/discussions/25217

* apply suggestion

* Fixing type errors on new pkgs (#1964)

* New smoke tests for detecting XCM and ETH failures (#1955)

* Added xcm failures smoke test

* Lint

* fixed spelling

* New smoke test to detect emulated Ethereum txn failures (#1961)

* Progress on paysFee

* Added new eth fail test

* Added tests new eth failed txn tests

* Lint

* Reverted vsc settings.json

* Update settings.json

for some reason prettier was flagging this as error despite on ignore list.

* Update settings.json

* prettier

* prettier

* update sha3 and libsecp256k1 dependencies (#1959)

* fix(ci): job prepare-polkadot must never be skipped (#1967)

* Moonbeam polkadot v0.9.32 (#1933)

* UPdate tomls

* bump ethereum types

* pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin

* asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin

* author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin

* ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin

* maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin

* migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin

* moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin

* proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin

* randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin

* xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin

* FMT

* assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* new cargo lock

* Fix error on toml

* pallet-democracy:runtimecall, runtime:origin

* staking-precomp:runtimecall, runtime:origin

* democracy-precomp:runtimecall, runtimeorigin

* randomness-precomp:runtimecall, runtimeorigin

* relay-encoder-precomp:runtimecall, runtimeorigin

* xcm-transactor-precomp:runtimecall, runtimeorigin

* xcm-utils-precomp:runtimecall, runtimeorigin

* xtokens-precomp:runtimecall, runtimeorigin

* precompile fmt

* Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin

* Fix moonbase runtime, which compiles now

* Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall

* moonbeam

* Adapt everything to clap 4.0.9

* FMT and fix democracy precompiles

* Start fixing pallet-democracy precompile tests

* BRing back note_preimage tests, imminent is removed

* Bring back imminent preimage

* moonbase tests updated

* FMT

* moonriver tests working

* install protoc in ci

* try again without sudo

* try again, this time manually

* Moonriver fmt, test fixes

* Fix moonbeam rust tests

* Fix last rust tests

* Adapt weight calculus to new weight system

* start fixing typescript tests

* Keep fixing tests

* Dispatch info now returns with base weight

* fix queue now new weight

* Keep fixing new weight related tests

* remove proto installation

* fix again github job

* Point at official evm and ethereum crates

* Debugging scheduler not working

* Keep fixing bounded democracy test calls

* Fix crowdloan democracy test

* Keep fixing tests

* More fixes related to weights and democracy

* FMT

* toml sort

* prettier

* more prettier

* compile benchmarks

* toml sort

* remove warning

* remove unused var

* Cargo lock

* fix proxy-governance test

* change democracy-proposal test

* More fixes

* Fix latest of democracy tests

* Add remaining migrations from BoundedCall

* Upgrade to 0.9.32

* FMT

* toml sort

* prettier

* editorconfig

* update polkadot api

* fix ega

* add proxy filters, this time in create_pure and kill_pure

* Add couple of db reads

* remove some as anys

* Revert "remove some as anys"

This reverts commit 5c9294a.

* fix try-runtime

* try-runtime hooks being executed

* Add pr suggestions

* warnings cleared

* more unused imports

* Fix merge error

* prettier

* add when runtime migrations were completed

* remove migrations that have already run and that require maintenance

* Preimage lazy migration (#1962)

* migration call

* add new migration Call to runtimes

* unit tests

* benchmarking

* Benchmarking from the benchmarking server

* toml fmt

Co-authored-by: girazoki <[email protected]>

* fmt

* 0.9.31 ts fixes (#1966)

* ts fixes

* small fixes

* lint

Co-authored-by: nanocryk <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Crystalin <[email protected]>

* fix workflow check features (#1970)

* types for runtime 2000

Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: bear <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Éloïs <[email protected]>
Co-authored-by: Qinxuan Chen <[email protected]>
Co-authored-by: girazoki <[email protected]>
Co-authored-by: nanocryk <[email protected]>
crystalin added a commit that referenced this pull request Nov 28, 2022
@github-actions @crystalin
@librelois @nbaztec @4meta5 @boundless-forest @timbrinded @koushiro @girazoki @nanocryk
Upgrade typescript API for runtime 2000 (#1938)
682fe03 
* typescript API v0.1901.0"

* regen typescript api

* update moonbeam/moonbeam-types-bundle/package-lock.json

* Updates dependencies

* Typescript api 2000 (#1973)

* fix staking benchmark tests (#1951)

* remove reward for delegator warn logs (#1895)

* Add once (#1857)

* Added tests for standard eth RPC methods (#1949)

* Added standard eth RPC tests

* reduced line length

* Added testskip for FullFilter pool

* bump client and runtime versions (#1910)

* Fix CI for external pr (#1963)

* remove useless job docker-parachain

* fix if condition for exterrnal PRs

solution find here: https://github.com/orgs/community/discussions/25217

* apply suggestion

* Fixing type errors on new pkgs (#1964)

* New smoke tests for detecting XCM and ETH failures (#1955)

* Added xcm failures smoke test

* Lint

* fixed spelling

* New smoke test to detect emulated Ethereum txn failures (#1961)

* Progress on paysFee

* Added new eth fail test

* Added tests new eth failed txn tests

* Lint

* Reverted vsc settings.json

* Update settings.json

for some reason prettier was flagging this as error despite on ignore list.

* Update settings.json

* prettier

* prettier

* update sha3 and libsecp256k1 dependencies (#1959)

* fix(ci): job prepare-polkadot must never be skipped (#1967)

* Moonbeam polkadot v0.9.32 (#1933)

* UPdate tomls

* bump ethereum types

* pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin

* asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin

* author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin

* ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin

* maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin

* migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin

* moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin

* proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin

* randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin

* xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin

* FMT

* assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* new cargo lock

* Fix error on toml

* pallet-democracy:runtimecall, runtime:origin

* staking-precomp:runtimecall, runtime:origin

* democracy-precomp:runtimecall, runtimeorigin

* randomness-precomp:runtimecall, runtimeorigin

* relay-encoder-precomp:runtimecall, runtimeorigin

* xcm-transactor-precomp:runtimecall, runtimeorigin

* xcm-utils-precomp:runtimecall, runtimeorigin

* xtokens-precomp:runtimecall, runtimeorigin

* precompile fmt

* Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin

* Fix moonbase runtime, which compiles now

* Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall

* moonbeam

* Adapt everything to clap 4.0.9

* FMT and fix democracy precompiles

* Start fixing pallet-democracy precompile tests

* BRing back note_preimage tests, imminent is removed

* Bring back imminent preimage

* moonbase tests updated

* FMT

* moonriver tests working

* install protoc in ci

* try again without sudo

* try again, this time manually

* Moonriver fmt, test fixes

* Fix moonbeam rust tests

* Fix last rust tests

* Adapt weight calculus to new weight system

* start fixing typescript tests

* Keep fixing tests

* Dispatch info now returns with base weight

* fix queue now new weight

* Keep fixing new weight related tests

* remove proto installation

* fix again github job

* Point at official evm and ethereum crates

* Debugging scheduler not working

* Keep fixing bounded democracy test calls

* Fix crowdloan democracy test

* Keep fixing tests

* More fixes related to weights and democracy

* FMT

* toml sort

* prettier

* more prettier

* compile benchmarks

* toml sort

* remove warning

* remove unused var

* Cargo lock

* fix proxy-governance test

* change democracy-proposal test

* More fixes

* Fix latest of democracy tests

* Add remaining migrations from BoundedCall

* Upgrade to 0.9.32

* FMT

* toml sort

* prettier

* editorconfig

* update polkadot api

* fix ega

* add proxy filters, this time in create_pure and kill_pure

* Add couple of db reads

* remove some as anys

* Revert "remove some as anys"

This reverts commit 5c9294a.

* fix try-runtime

* try-runtime hooks being executed

* Add pr suggestions

* warnings cleared

* more unused imports

* Fix merge error

* prettier

* add when runtime migrations were completed

* remove migrations that have already run and that require maintenance

* Preimage lazy migration (#1962)

* migration call

* add new migration Call to runtimes

* unit tests

* benchmarking

* Benchmarking from the benchmarking server

* toml fmt

Co-authored-by: girazoki <[email protected]>

* fmt

* 0.9.31 ts fixes (#1966)

* ts fixes

* small fixes

* lint

Co-authored-by: nanocryk <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Crystalin <[email protected]>

* fix workflow check features (#1970)

* types for runtime 2000

Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: bear <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Éloïs <[email protected]>
Co-authored-by: Qinxuan Chen <[email protected]>
Co-authored-by: girazoki <[email protected]>
Co-authored-by: nanocryk <[email protected]>

* Updates test api-augment

* Upgrade typescripts

Co-authored-by: crystalin <[email protected]>
Co-authored-by: librelois <[email protected]>
Co-authored-by: Crystalin <[email protected]>
Co-authored-by: Alan Sapede <[email protected]>
Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: bear <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Qinxuan Chen <[email protected]>
Co-authored-by: girazoki <[email protected]>
Co-authored-by: nanocryk <[email protected]>
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@librelois @imstar15
fix workflow check features (moonbeam-foundation#1970)
0a4f0ce
imstar15 pushed a commit to AvaProtocol/moonbeam that referenced this pull request May 16, 2023
@github-actions @crystalin
@librelois @nbaztec @4meta5 @boundless-forest @timbrinded @koushiro @girazoki @nanocryk @imstar15
Upgrade typescript API for runtime 2000 (moonbeam-foundation#1938)
dcca39b 
* typescript API v0.1901.0"

* regen typescript api

* update moonbeam/moonbeam-types-bundle/package-lock.json

* Updates dependencies

* Typescript api 2000 (moonbeam-foundation#1973)

* fix staking benchmark tests (moonbeam-foundation#1951)

* remove reward for delegator warn logs (moonbeam-foundation#1895)

* Add once (moonbeam-foundation#1857)

* Added tests for standard eth RPC methods (moonbeam-foundation#1949)

* Added standard eth RPC tests

* reduced line length

* Added testskip for FullFilter pool

* bump client and runtime versions (moonbeam-foundation#1910)

* Fix CI for external pr (moonbeam-foundation#1963)

* remove useless job docker-parachain

* fix if condition for exterrnal PRs

solution find here: https://github.com/orgs/community/discussions/25217

* apply suggestion

* Fixing type errors on new pkgs (moonbeam-foundation#1964)

* New smoke tests for detecting XCM and ETH failures (moonbeam-foundation#1955)

* Added xcm failures smoke test

* Lint

* fixed spelling

* New smoke test to detect emulated Ethereum txn failures (moonbeam-foundation#1961)

* Progress on paysFee

* Added new eth fail test

* Added tests new eth failed txn tests

* Lint

* Reverted vsc settings.json

* Update settings.json

for some reason prettier was flagging this as error despite on ignore list.

* Update settings.json

* prettier

* prettier

* update sha3 and libsecp256k1 dependencies (moonbeam-foundation#1959)

* fix(ci): job prepare-polkadot must never be skipped (moonbeam-foundation#1967)

* Moonbeam polkadot v0.9.32 (moonbeam-foundation#1933)

* UPdate tomls

* bump ethereum types

* pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin

* asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin

* author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin

* ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin

* maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin

* migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin

* moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin

* proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin

* randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin

* xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin

* FMT

* assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights

* new cargo lock

* Fix error on toml

* pallet-democracy:runtimecall, runtime:origin

* staking-precomp:runtimecall, runtime:origin

* democracy-precomp:runtimecall, runtimeorigin

* randomness-precomp:runtimecall, runtimeorigin

* relay-encoder-precomp:runtimecall, runtimeorigin

* xcm-transactor-precomp:runtimecall, runtimeorigin

* xcm-utils-precomp:runtimecall, runtimeorigin

* xtokens-precomp:runtimecall, runtimeorigin

* precompile fmt

* Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin

* Fix moonbase runtime, which compiles now

* Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall

* moonbeam

* Adapt everything to clap 4.0.9

* FMT and fix democracy precompiles

* Start fixing pallet-democracy precompile tests

* BRing back note_preimage tests, imminent is removed

* Bring back imminent preimage

* moonbase tests updated

* FMT

* moonriver tests working

* install protoc in ci

* try again without sudo

* try again, this time manually

* Moonriver fmt, test fixes

* Fix moonbeam rust tests

* Fix last rust tests

* Adapt weight calculus to new weight system

* start fixing typescript tests

* Keep fixing tests

* Dispatch info now returns with base weight

* fix queue now new weight

* Keep fixing new weight related tests

* remove proto installation

* fix again github job

* Point at official evm and ethereum crates

* Debugging scheduler not working

* Keep fixing bounded democracy test calls

* Fix crowdloan democracy test

* Keep fixing tests

* More fixes related to weights and democracy

* FMT

* toml sort

* prettier

* more prettier

* compile benchmarks

* toml sort

* remove warning

* remove unused var

* Cargo lock

* fix proxy-governance test

* change democracy-proposal test

* More fixes

* Fix latest of democracy tests

* Add remaining migrations from BoundedCall

* Upgrade to 0.9.32

* FMT

* toml sort

* prettier

* editorconfig

* update polkadot api

* fix ega

* add proxy filters, this time in create_pure and kill_pure

* Add couple of db reads

* remove some as anys

* Revert "remove some as anys"

This reverts commit 5c9294a.

* fix try-runtime

* try-runtime hooks being executed

* Add pr suggestions

* warnings cleared

* more unused imports

* Fix merge error

* prettier

* add when runtime migrations were completed

* remove migrations that have already run and that require maintenance

* Preimage lazy migration (moonbeam-foundation#1962)

* migration call

* add new migration Call to runtimes

* unit tests

* benchmarking

* Benchmarking from the benchmarking server

* toml fmt

Co-authored-by: girazoki <[email protected]>

* fmt

* 0.9.31 ts fixes (moonbeam-foundation#1966)

* ts fixes

* small fixes

* lint

Co-authored-by: nanocryk <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Crystalin <[email protected]>

* fix workflow check features (moonbeam-foundation#1970)

* types for runtime 2000

Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: bear <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Éloïs <[email protected]>
Co-authored-by: Qinxuan Chen <[email protected]>
Co-authored-by: girazoki <[email protected]>
Co-authored-by: nanocryk <[email protected]>

* Updates test api-augment

* Upgrade typescripts

Co-authored-by: crystalin <[email protected]>
Co-authored-by: librelois <[email protected]>
Co-authored-by: Crystalin <[email protected]>
Co-authored-by: Alan Sapede <[email protected]>
Co-authored-by: Nisheeth Barthwal <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Co-authored-by: bear <[email protected]>
Co-authored-by: Tim B <[email protected]>
Co-authored-by: Qinxuan Chen <[email protected]>
Co-authored-by: girazoki <[email protected]>
Co-authored-by: nanocryk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girazoki girazoki girazoki approved these changes

@crystalin crystalin Awaiting requested review from crystalin

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@librelois @crystalin @mario-sangar @girazoki