-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moonbeam polkadot v0.9.32 #1933
Conversation
This reverts commit 5c9294a.
@@ -305,7 +323,7 @@ pub mod pallet { | |||
<MigrationState<T>>::insert(migration_name_as_bytes, true); | |||
|
|||
weight = weight.saturating_add(consumed_weight); | |||
if weight > available_weight { | |||
if weight.ref_time() > available_weight.ref_time() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be great when we can also check against PoV here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, didnt want to include for now...I guess it can be a follow-up PR
Your |
* migration call * add new migration Call to runtimes * unit tests * benchmarking * Benchmarking from the benchmarking server * toml fmt Co-authored-by: girazoki <[email protected]>
* ts fixes * small fixes * lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, suggested non-blocking changes in pre/post migration code.
Self::get_temp_storage("example_pair").expect("qed"); | ||
if state_vec.len() > 0 { | ||
let (old_mapping_count, (asset_id, units)) = | ||
state_vec.first().expect("we should have an element"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we check the length of state_vec
and then use state_vec.first
?
Since this is the output of pre_upgrade
there should be such element and thus we should not skip the check if it is empty (it should NOT be empty). Also since there is a single value we could avoid using a Vec and only encode/decode a (u32, (T::AssetId, u128))
.
(same remark for all other pre_upgrade/post_upgrade in this file, functions in author-mapping seems to already do that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I made such that you can run these checks even if the migration has already passed (i.e., there is no element to migrate). But we can remove it if we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the vec is actually what allows us to succeed when migrating nothing (we could use options too)
* fix staking benchmark tests (#1951) * remove reward for delegator warn logs (#1895) * Add once (#1857) * Added tests for standard eth RPC methods (#1949) * Added standard eth RPC tests * reduced line length * Added testskip for FullFilter pool * bump client and runtime versions (#1910) * Fix CI for external pr (#1963) * remove useless job docker-parachain * fix if condition for exterrnal PRs solution find here: https://github.com/orgs/community/discussions/25217 * apply suggestion * Fixing type errors on new pkgs (#1964) * New smoke tests for detecting XCM and ETH failures (#1955) * Added xcm failures smoke test * Lint * fixed spelling * New smoke test to detect emulated Ethereum txn failures (#1961) * Progress on paysFee * Added new eth fail test * Added tests new eth failed txn tests * Lint * Reverted vsc settings.json * Update settings.json for some reason prettier was flagging this as error despite on ignore list. * Update settings.json * prettier * prettier * update sha3 and libsecp256k1 dependencies (#1959) * fix(ci): job prepare-polkadot must never be skipped (#1967) * Moonbeam polkadot v0.9.32 (#1933) * UPdate tomls * bump ethereum types * pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin * asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin * author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin * ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin * maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin * migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin * moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin * proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin * randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin * xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin * FMT * assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * new cargo lock * Fix error on toml * pallet-democracy:runtimecall, runtime:origin * staking-precomp:runtimecall, runtime:origin * democracy-precomp:runtimecall, runtimeorigin * randomness-precomp:runtimecall, runtimeorigin * relay-encoder-precomp:runtimecall, runtimeorigin * xcm-transactor-precomp:runtimecall, runtimeorigin * xcm-utils-precomp:runtimecall, runtimeorigin * xtokens-precomp:runtimecall, runtimeorigin * precompile fmt * Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin * Fix moonbase runtime, which compiles now * Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall * moonbeam * Adapt everything to clap 4.0.9 * FMT and fix democracy precompiles * Start fixing pallet-democracy precompile tests * BRing back note_preimage tests, imminent is removed * Bring back imminent preimage * moonbase tests updated * FMT * moonriver tests working * install protoc in ci * try again without sudo * try again, this time manually * Moonriver fmt, test fixes * Fix moonbeam rust tests * Fix last rust tests * Adapt weight calculus to new weight system * start fixing typescript tests * Keep fixing tests * Dispatch info now returns with base weight * fix queue now new weight * Keep fixing new weight related tests * remove proto installation * fix again github job * Point at official evm and ethereum crates * Debugging scheduler not working * Keep fixing bounded democracy test calls * Fix crowdloan democracy test * Keep fixing tests * More fixes related to weights and democracy * FMT * toml sort * prettier * more prettier * compile benchmarks * toml sort * remove warning * remove unused var * Cargo lock * fix proxy-governance test * change democracy-proposal test * More fixes * Fix latest of democracy tests * Add remaining migrations from BoundedCall * Upgrade to 0.9.32 * FMT * toml sort * prettier * editorconfig * update polkadot api * fix ega * add proxy filters, this time in create_pure and kill_pure * Add couple of db reads * remove some as anys * Revert "remove some as anys" This reverts commit 5c9294a. * fix try-runtime * try-runtime hooks being executed * Add pr suggestions * warnings cleared * more unused imports * Fix merge error * prettier * add when runtime migrations were completed * remove migrations that have already run and that require maintenance * Preimage lazy migration (#1962) * migration call * add new migration Call to runtimes * unit tests * benchmarking * Benchmarking from the benchmarking server * toml fmt Co-authored-by: girazoki <[email protected]> * fmt * 0.9.31 ts fixes (#1966) * ts fixes * small fixes * lint Co-authored-by: nanocryk <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Crystalin <[email protected]> * fix workflow check features (#1970) * types for runtime 2000 Co-authored-by: Nisheeth Barthwal <[email protected]> Co-authored-by: Amar Singh <[email protected]> Co-authored-by: bear <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Éloïs <[email protected]> Co-authored-by: Qinxuan Chen <[email protected]> Co-authored-by: girazoki <[email protected]> Co-authored-by: nanocryk <[email protected]>
* typescript API v0.1901.0" * regen typescript api * update moonbeam/moonbeam-types-bundle/package-lock.json * Updates dependencies * Typescript api 2000 (#1973) * fix staking benchmark tests (#1951) * remove reward for delegator warn logs (#1895) * Add once (#1857) * Added tests for standard eth RPC methods (#1949) * Added standard eth RPC tests * reduced line length * Added testskip for FullFilter pool * bump client and runtime versions (#1910) * Fix CI for external pr (#1963) * remove useless job docker-parachain * fix if condition for exterrnal PRs solution find here: https://github.com/orgs/community/discussions/25217 * apply suggestion * Fixing type errors on new pkgs (#1964) * New smoke tests for detecting XCM and ETH failures (#1955) * Added xcm failures smoke test * Lint * fixed spelling * New smoke test to detect emulated Ethereum txn failures (#1961) * Progress on paysFee * Added new eth fail test * Added tests new eth failed txn tests * Lint * Reverted vsc settings.json * Update settings.json for some reason prettier was flagging this as error despite on ignore list. * Update settings.json * prettier * prettier * update sha3 and libsecp256k1 dependencies (#1959) * fix(ci): job prepare-polkadot must never be skipped (#1967) * Moonbeam polkadot v0.9.32 (#1933) * UPdate tomls * bump ethereum types * pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin * asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin * author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin * ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin * maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin * migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin * moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin * proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin * randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin * xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin * FMT * assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * new cargo lock * Fix error on toml * pallet-democracy:runtimecall, runtime:origin * staking-precomp:runtimecall, runtime:origin * democracy-precomp:runtimecall, runtimeorigin * randomness-precomp:runtimecall, runtimeorigin * relay-encoder-precomp:runtimecall, runtimeorigin * xcm-transactor-precomp:runtimecall, runtimeorigin * xcm-utils-precomp:runtimecall, runtimeorigin * xtokens-precomp:runtimecall, runtimeorigin * precompile fmt * Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin * Fix moonbase runtime, which compiles now * Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall * moonbeam * Adapt everything to clap 4.0.9 * FMT and fix democracy precompiles * Start fixing pallet-democracy precompile tests * BRing back note_preimage tests, imminent is removed * Bring back imminent preimage * moonbase tests updated * FMT * moonriver tests working * install protoc in ci * try again without sudo * try again, this time manually * Moonriver fmt, test fixes * Fix moonbeam rust tests * Fix last rust tests * Adapt weight calculus to new weight system * start fixing typescript tests * Keep fixing tests * Dispatch info now returns with base weight * fix queue now new weight * Keep fixing new weight related tests * remove proto installation * fix again github job * Point at official evm and ethereum crates * Debugging scheduler not working * Keep fixing bounded democracy test calls * Fix crowdloan democracy test * Keep fixing tests * More fixes related to weights and democracy * FMT * toml sort * prettier * more prettier * compile benchmarks * toml sort * remove warning * remove unused var * Cargo lock * fix proxy-governance test * change democracy-proposal test * More fixes * Fix latest of democracy tests * Add remaining migrations from BoundedCall * Upgrade to 0.9.32 * FMT * toml sort * prettier * editorconfig * update polkadot api * fix ega * add proxy filters, this time in create_pure and kill_pure * Add couple of db reads * remove some as anys * Revert "remove some as anys" This reverts commit 5c9294a. * fix try-runtime * try-runtime hooks being executed * Add pr suggestions * warnings cleared * more unused imports * Fix merge error * prettier * add when runtime migrations were completed * remove migrations that have already run and that require maintenance * Preimage lazy migration (#1962) * migration call * add new migration Call to runtimes * unit tests * benchmarking * Benchmarking from the benchmarking server * toml fmt Co-authored-by: girazoki <[email protected]> * fmt * 0.9.31 ts fixes (#1966) * ts fixes * small fixes * lint Co-authored-by: nanocryk <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Crystalin <[email protected]> * fix workflow check features (#1970) * types for runtime 2000 Co-authored-by: Nisheeth Barthwal <[email protected]> Co-authored-by: Amar Singh <[email protected]> Co-authored-by: bear <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Éloïs <[email protected]> Co-authored-by: Qinxuan Chen <[email protected]> Co-authored-by: girazoki <[email protected]> Co-authored-by: nanocryk <[email protected]> * Updates test api-augment * Upgrade typescripts Co-authored-by: crystalin <[email protected]> Co-authored-by: librelois <[email protected]> Co-authored-by: Crystalin <[email protected]> Co-authored-by: Alan Sapede <[email protected]> Co-authored-by: Nisheeth Barthwal <[email protected]> Co-authored-by: Amar Singh <[email protected]> Co-authored-by: bear <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Qinxuan Chen <[email protected]> Co-authored-by: girazoki <[email protected]> Co-authored-by: nanocryk <[email protected]>
* UPdate tomls * bump ethereum types * pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin * asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin * author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin * ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin * maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin * migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin * moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin * proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin * randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin * xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin * FMT * assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * new cargo lock * Fix error on toml * pallet-democracy:runtimecall, runtime:origin * staking-precomp:runtimecall, runtime:origin * democracy-precomp:runtimecall, runtimeorigin * randomness-precomp:runtimecall, runtimeorigin * relay-encoder-precomp:runtimecall, runtimeorigin * xcm-transactor-precomp:runtimecall, runtimeorigin * xcm-utils-precomp:runtimecall, runtimeorigin * xtokens-precomp:runtimecall, runtimeorigin * precompile fmt * Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin * Fix moonbase runtime, which compiles now * Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall * moonbeam * Adapt everything to clap 4.0.9 * FMT and fix democracy precompiles * Start fixing pallet-democracy precompile tests * BRing back note_preimage tests, imminent is removed * Bring back imminent preimage * moonbase tests updated * FMT * moonriver tests working * install protoc in ci * try again without sudo * try again, this time manually * Moonriver fmt, test fixes * Fix moonbeam rust tests * Fix last rust tests * Adapt weight calculus to new weight system * start fixing typescript tests * Keep fixing tests * Dispatch info now returns with base weight * fix queue now new weight * Keep fixing new weight related tests * remove proto installation * fix again github job * Point at official evm and ethereum crates * Debugging scheduler not working * Keep fixing bounded democracy test calls * Fix crowdloan democracy test * Keep fixing tests * More fixes related to weights and democracy * FMT * toml sort * prettier * more prettier * compile benchmarks * toml sort * remove warning * remove unused var * Cargo lock * fix proxy-governance test * change democracy-proposal test * More fixes * Fix latest of democracy tests * Add remaining migrations from BoundedCall * Upgrade to 0.9.32 * FMT * toml sort * prettier * editorconfig * update polkadot api * fix ega * add proxy filters, this time in create_pure and kill_pure * Add couple of db reads * remove some as anys * Revert "remove some as anys" This reverts commit 5c9294a. * fix try-runtime * try-runtime hooks being executed * Add pr suggestions * warnings cleared * more unused imports * Fix merge error * prettier * add when runtime migrations were completed * remove migrations that have already run and that require maintenance * Preimage lazy migration (moonbeam-foundation#1962) * migration call * add new migration Call to runtimes * unit tests * benchmarking * Benchmarking from the benchmarking server * toml fmt Co-authored-by: girazoki <[email protected]> * fmt * 0.9.31 ts fixes (moonbeam-foundation#1966) * ts fixes * small fixes * lint Co-authored-by: nanocryk <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Crystalin <[email protected]>
* typescript API v0.1901.0" * regen typescript api * update moonbeam/moonbeam-types-bundle/package-lock.json * Updates dependencies * Typescript api 2000 (moonbeam-foundation#1973) * fix staking benchmark tests (moonbeam-foundation#1951) * remove reward for delegator warn logs (moonbeam-foundation#1895) * Add once (moonbeam-foundation#1857) * Added tests for standard eth RPC methods (moonbeam-foundation#1949) * Added standard eth RPC tests * reduced line length * Added testskip for FullFilter pool * bump client and runtime versions (moonbeam-foundation#1910) * Fix CI for external pr (moonbeam-foundation#1963) * remove useless job docker-parachain * fix if condition for exterrnal PRs solution find here: https://github.com/orgs/community/discussions/25217 * apply suggestion * Fixing type errors on new pkgs (moonbeam-foundation#1964) * New smoke tests for detecting XCM and ETH failures (moonbeam-foundation#1955) * Added xcm failures smoke test * Lint * fixed spelling * New smoke test to detect emulated Ethereum txn failures (moonbeam-foundation#1961) * Progress on paysFee * Added new eth fail test * Added tests new eth failed txn tests * Lint * Reverted vsc settings.json * Update settings.json for some reason prettier was flagging this as error despite on ignore list. * Update settings.json * prettier * prettier * update sha3 and libsecp256k1 dependencies (moonbeam-foundation#1959) * fix(ci): job prepare-polkadot must never be skipped (moonbeam-foundation#1967) * Moonbeam polkadot v0.9.32 (moonbeam-foundation#1933) * UPdate tomls * bump ethereum types * pallet-staking: RuntimeEvent, RUntimeCall, RuntimeOrigin * asset-manager: RuntimeEvent, RUntimeCall, RuntimeOrigin * author-mapping: RuntimeEvent, RUntimeCall, RuntimeOrigin * ethereum-xcm: RuntimeEvent, RUntimeCall, RuntimeOrigin * maintenance-mode: RuntimeEvent, RUntimeCall, RuntimeOrigin * migrations: RuntimeEvent, RUntimeCall, RuntimeOrigin * moonbeam-orbiters: RuntimeEvent, RUntimeCall, RuntimeOrigin * proxy-genesis: RuntimeEvent, RUntimeCall, RuntimeOrigin * randomness: RuntimeEvent, RUntimeCall, RuntimeOrigin * xcm-transactor: RuntimeEvent, RUntimeCall, RuntimeOrigin * FMT * assets-erc20-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * author-mapping-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * balances-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * batch-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * call-permit: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * collective-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * crowdloan-precomp: RuntimeEvent, RUntimeCall, RuntimeOrigin and new weights * new cargo lock * Fix error on toml * pallet-democracy:runtimecall, runtime:origin * staking-precomp:runtimecall, runtime:origin * democracy-precomp:runtimecall, runtimeorigin * randomness-precomp:runtimecall, runtimeorigin * relay-encoder-precomp:runtimecall, runtimeorigin * xcm-transactor-precomp:runtimecall, runtimeorigin * xcm-utils-precomp:runtimecall, runtimeorigin * xtokens-precomp:runtimecall, runtimeorigin * precompile fmt * Adapting moonbase to RuntimeEvent, RuntimeCall, RuntimeOrigin * Fix moonbase runtime, which compiles now * Adapt moonriver runtime to: democracy changes, RuntimeOrigin, RuntimeEvent, RuntimeCall * moonbeam * Adapt everything to clap 4.0.9 * FMT and fix democracy precompiles * Start fixing pallet-democracy precompile tests * BRing back note_preimage tests, imminent is removed * Bring back imminent preimage * moonbase tests updated * FMT * moonriver tests working * install protoc in ci * try again without sudo * try again, this time manually * Moonriver fmt, test fixes * Fix moonbeam rust tests * Fix last rust tests * Adapt weight calculus to new weight system * start fixing typescript tests * Keep fixing tests * Dispatch info now returns with base weight * fix queue now new weight * Keep fixing new weight related tests * remove proto installation * fix again github job * Point at official evm and ethereum crates * Debugging scheduler not working * Keep fixing bounded democracy test calls * Fix crowdloan democracy test * Keep fixing tests * More fixes related to weights and democracy * FMT * toml sort * prettier * more prettier * compile benchmarks * toml sort * remove warning * remove unused var * Cargo lock * fix proxy-governance test * change democracy-proposal test * More fixes * Fix latest of democracy tests * Add remaining migrations from BoundedCall * Upgrade to 0.9.32 * FMT * toml sort * prettier * editorconfig * update polkadot api * fix ega * add proxy filters, this time in create_pure and kill_pure * Add couple of db reads * remove some as anys * Revert "remove some as anys" This reverts commit 5c9294a. * fix try-runtime * try-runtime hooks being executed * Add pr suggestions * warnings cleared * more unused imports * Fix merge error * prettier * add when runtime migrations were completed * remove migrations that have already run and that require maintenance * Preimage lazy migration (moonbeam-foundation#1962) * migration call * add new migration Call to runtimes * unit tests * benchmarking * Benchmarking from the benchmarking server * toml fmt Co-authored-by: girazoki <[email protected]> * fmt * 0.9.31 ts fixes (moonbeam-foundation#1966) * ts fixes * small fixes * lint Co-authored-by: nanocryk <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Crystalin <[email protected]> * fix workflow check features (moonbeam-foundation#1970) * types for runtime 2000 Co-authored-by: Nisheeth Barthwal <[email protected]> Co-authored-by: Amar Singh <[email protected]> Co-authored-by: bear <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Éloïs <[email protected]> Co-authored-by: Qinxuan Chen <[email protected]> Co-authored-by: girazoki <[email protected]> Co-authored-by: nanocryk <[email protected]> * Updates test api-augment * Upgrade typescripts Co-authored-by: crystalin <[email protected]> Co-authored-by: librelois <[email protected]> Co-authored-by: Crystalin <[email protected]> Co-authored-by: Alan Sapede <[email protected]> Co-authored-by: Nisheeth Barthwal <[email protected]> Co-authored-by: Amar Singh <[email protected]> Co-authored-by: bear <[email protected]> Co-authored-by: Tim B <[email protected]> Co-authored-by: Qinxuan Chen <[email protected]> Co-authored-by: girazoki <[email protected]> Co-authored-by: nanocryk <[email protected]>
What does it do?
Updates Moonbeam and friends to the Polkadot v0.9.32 release. Also:
TODO
Call
paritytech/substrate#11649pallet-democracy
stops supporting PreImages storage, forcing us to use preimage-pallet: paritytech/substrate#11649. This breaks certain assumptions of our pallet-democracy precompiles:Before:
propose
precompile did not require the pre-image to exist.After:
propose
precompile requires the pre-image to exist in pallet-preimage.Before:
note_preimage
precompile stored preimages in pallet-democracy.After:
note_preimage
precompile stores preimages in pallet-preimages.try-runtime
API changed. Before we did utilizeset_temp_storage
andget_temp_storage
aux functions to make sure the state was properly migrated. Nowpre_upgrade
returns the state asVec<u8>
, which is supposed to represent the state to be verified scale-encoded. Accordingly,post_upgrade
receives such a state, decodes it, and runs necessary checks. (paritytech/substrate#12319)max_weight
to be used in the destination chain as a u64. Now they receive aWeightLimit
enum, withLimited(u64)
andUnlimited
variants. Limited aims at representing the previousmax_weight
, whileUnlimited
is used when we dont want to specify amax_weight
and we let the destination chain calculate it. (open-web3-stack/open-runtime-module-library#841)Call
,Origin
andEvent
runtime types have been renamed toRuntimeCall
,RuntimeOrigin
,RuntimeEvent
. (paritytech/substrate#12258, paritytech/substrate#11981)max_proof_size
has to be set when specifiying themaxBlockWeight
for the runtime. We set it to https://github.com/paritytech/polkadot/blob/a06097555c3d811184a30bed85d1238eca4ae2d6/primitives/src/v2/mod.rs#L390What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?