-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple environment-based PHP configuration #167
Conversation
9266002
to
08592a3
Compare
Note: This is intended to co-exist with the entrypoint changes - the rationale being that we should make it as easy as possible to make small changes, but still allow larger ones. Adding an environment variable is very easy. They are not mutually exclusive, and both are optional. We can provide neither, either, or both. |
Hi @andrewnicols, My trivial comment: why the The official image is actually using HTH, |
I'm happy to go with either if anyone has a preference. |
Fun, I was to comment also about the "INI" prefix when saw @scara already did. My point was more about future expansions we could do, like adding stuff to apache conf or git conf... or whatever. In any case, for me |
This adds a layer of common sense on top of the other changes I've worked on to allow easy configuration variable setting. Fixes moodlehq#166
I've updated the patch to change it to use PHP_INI instead. |
Sold, thanks! I'll be backporting this to php >= 74 images (like entrypoints @ #162). |
Done, all the php >= 74 images have been rebuilt to include this. |
This adds a layer of common sense on top of the other changes I've worked on to allow easy configuration variable setting.
This is currently based on top of #162 and #163 together, but can be refactored easily.
The tl;dr is:
Will cause a new php.ini file to be created at `/usr/local/etc/php/conf.d/10-local.ini containing: