Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php.ini modification instructions #107

Closed
wants to merge 1 commit into from

Conversation

nadavkav
Copy link

@nadavkav nadavkav commented Apr 9, 2020

Trying to upload a large course backup into the Moodle docker instance, I was limited by php.ini max upload settings.
So I propose adding some instructions about updating php.ini within the running docker

Trying to upload a large course backup into the Moodle docker instance, I was limited by php.ini max upload settings.
So I propose adding some instructions about updating php.ini within the running docker
@stronk7 stronk7 force-pushed the master branch 5 times, most recently from 3954ec8 to fe69e99 Compare August 14, 2021 18:39
@stronk7
Copy link
Member

stronk7 commented Aug 19, 2021

Uhm... don't this need to restart the service for the changes to make effect?

@nadavkav
Copy link
Author

You are right @stronk7 , but it was so obvious that I failed to mention it.
Revisiting this, I think the initial max upload size should be much higher then what it is today, to support uploading of large
course backups for testing purposes out of the box. (our case)

@davidscotson
Copy link

Can we add these settings to https://github.com/moodlehq/moodle-php-apache/blob/master/root/usr/local/etc/php/conf.d/docker-php-moodle.ini as I think they're generally helpful.

Might be nice to have instructions for other settings though.

@stronk7 stronk7 mentioned this pull request Sep 24, 2021
@stronk7 stronk7 force-pushed the master branch 8 times, most recently from a4865f6 to 2a8ac52 Compare January 26, 2023 23:10
@stronk7
Copy link
Member

stronk7 commented Mar 18, 2023

Hi,

I think that now, both with #162 and #167 (both documented in the main readme) it's pretty easy to add any script and/or php configuration.

So I feel that this can be closed now, thanks for your contribution!

If you think that still we should do something else, don't hesitate to open a new issue / PR.

Ciao :-)

@stronk7 stronk7 closed this Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants