-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Correct order for in-course breadcrumb when sections exist in it (First categories then sections) #483
Bugfix: Correct order for in-course breadcrumb when sections exist in it (First categories then sections) #483
Conversation
d021aab
to
4c0832b
Compare
f00b855
to
1be27b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @danowar2k , many thanks for working on this bug!
The fact that the order is wrong in the breadcrumb is clearly a bug and your patch solves this bug.
I have just rebased your branch onto latest master, have generalized the Behat steps which have been introduced by you a little bit and have pushed it to your branch again.
However, I have one questions regarding your Behat scenario which I would like to ask you to answer before we merge this.
In addition to that, I have raised #593 and #594 as follow-up issues. I would be grateful if you could have a look at these as well.
@danowar2k - I do not want to bug you, but I would appreciate your answer to the question above. As soon as I have understood your intention, I will be able to finish the review and merge the PR. |
Whoops, completely overlooked this among the many other mails I'm getting from Boost Union on Github. I should probably change my notification settings... Sorry, will look into it |
… it (First categories then sections), solves moodle-an-hochschulen#317
1be27b9
to
997e019
Compare
Thanks, @danowar2k , I think I got your point now. Regarding your comment about the fact that "Enrolment options" string could be a link: I think this would be solved as soon as #594 would be solved. In this case, the course main page would be shown between the category name and the "Enrolment options" strings as an additional breadcrumb item. If you have some spare time, I would be grateful if you could look into that issue. Cheers, |
… it (First categories then sections) (#483)
… it (First categories then sections) (#483)
… it (First categories then sections) (#483)
… it (First categories then sections) (moodle-an-hochschulen#483)
Solves #317