Improvement: Maybe the categorybreadcrumbs setting could use less dupliated code #593
Labels
improvement
Something which improves an existing feature in some way (UX, UI, Design, Functionality)
This is a follow-up issue to #317 / #483:
@danowar2k commented in #317:
The Boost Union setting
categorybreadcrumbs
is there to show a breadcrumb on the course overview pages. This is something which the Moodle core does not do in any way anymore, even not ifnavshowcategories
ornavshowmycoursecategories
is enabled.But basically, @danowar2k is right:
To realize the Boost Union setting
categorybreadcrumbs
, a large amount of code has been duplicated into Boost Union - the /classes/boostnavbar.php class file has been duplicated and the get_course_categories() function from lib/navigation.lib has been added to this file.It would be worthwhile to investigate if at least a part of the duplicated code can be refactored to use Moodle core functions instead to avoid issues like #317 in the future.
The text was updated successfully, but these errors were encountered: