Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET to 8.0 #2927

Merged
merged 27 commits into from
Jul 25, 2024
Merged

Update .NET to 8.0 #2927

merged 27 commits into from
Jul 25, 2024

Conversation

mattleibow
Copy link
Contributor

Description of Change

Updating .NET to the latest stable and prepare for .NET 9.0.

@benbaker76
Copy link

Please include an update to the install-dotnet-workloads.ps1 so it will build using the latest wasm-tools

@mattleibow
Copy link
Contributor Author

@benbaker76
Copy link

benbaker76 commented Jul 22, 2024

It is there:

When publishing for a Blazor Wasm (.NET 8.0) project it forced me to install wasm-tools-net6 or it would give me an error To build this project, the following workloads must be installed: wasm-tools-net6. To install these workloads, run the following command: dotnet workload restore.

I'm using Svg.Skia along with SkiaSharp.Views.Blazor. Without the latter I'd get System.DllNotFoundException: libSkiaSharp (previously I tried SkiaSharp.NativeAssets.WebAssembly instead but it didn't work).

@mattleibow
Copy link
Contributor Author

What are you deploying? The wasm-tools-net6 is only used in net6, and I think nothing is using that in this repo after this PR?

@benbaker76
Copy link

What are you deploying? The wasm-tools-net6 is only used in net6, and I think nothing is using that in this repo after this PR?

My concern is that the script is specifically referring to wasm-tools-net6 rather than the latest (just wasm-tools) but you may be right in that it will use the latest once this PR is merged. I look forward to it and thanks for your work on the project.

@mattleibow mattleibow merged commit 171e086 into main Jul 25, 2024
2 checks passed
@mattleibow mattleibow deleted the dev/updates branch July 25, 2024 16:28
@jairbubbles
Copy link

Hi @mattleibow, do you plan to release a preview package that works on net9.0 + wasm?

With [email protected] I get:

System.DllNotFoundException: libSkiaSharp

When tweaking SkiaSharp.NativeAssets.WebAssembly.targets locally to include the native files I get a bit further but ends up with:

Unhandled exception rendering component: Could not set up parent class, due to: Could not load type of field 'SkiaSharp.Views.Blazor.Internal.JSModuleInterop:moduleTask' (0) due to: Could not resolve type with token 0100003b from typeref (expected class 'Microsoft.JSInterop.IJSUnmarshalledObjectReference' in assembly 'Microsoft.JSInterop, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60') assembly:Microsoft.JSInterop, Version=6.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60 type:Microsoft.JSInterop.IJSUnmarshalledObjectReference member:(null) assembly:SkiaSharp.Views.Blazor.dll type:JSModuleInterop member:(null)

Please note that I'm trying in .NET 9 as I want to try out:

<WasmEnableThreads>true</WasmEnableThreads>

Which comes with its own set of issues 😅

Thank you!

@mattleibow
Copy link
Contributor Author

Lets talk on this PR that I stopped as things were not actually implemented in .NET at the time: #2620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants