Add the GPU views for Uno Platform #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
commented
Jul 24, 2020
source/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.Android/SKSwapChainPanel.Android.cs
Outdated
Show resolved
Hide resolved
| public int Depth { get; set; } | ||
| } | ||
|
|
||
| private class SKSwapChainPanelJsInterop : IJSObject, IJSObjectMetadata |
There was a problem hiding this comment.
I believe this is the correct way to do things in v2, not so sure about v3.
source/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.Wasm/WasmScripts/SkiaSharp.Views.Uno.Wasm.js
Show resolved
Hide resolved
Comment on lines
53
to
65
| [NotImplemented] | ||
| public bool DrawInBackground | ||
| { | ||
| get => throw new NotImplementedException(); | ||
| set => throw new NotImplementedException(); | ||
| } | ||
|
|
||
| [NotImplemented] | ||
| public bool EnableRenderLoop | ||
| { | ||
| get => throw new NotImplementedException(); | ||
| set => throw new NotImplementedException(); | ||
| } |
There was a problem hiding this comment.
Just a TODO for v1.
Comment on lines
+105
to
+107
| loadUnloadCounter++; | ||
| if (loadUnloadCounter != 1) | ||
| return; |
There was a problem hiding this comment.
Not actually sure Uno also has the "feature-bug" #1118
jeromelaban
reviewed
Jul 24, 2020
source/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.Android/SKSwapChainPanel.Android.cs
Outdated
Show resolved
Hide resolved
| private SKSizeI lastSize; | ||
|
|
||
| public SKSwapChainPanel() | ||
| : base("canvas") |
There was a problem hiding this comment.
This will change with Uno 3 (HtmlElementAttribute)
source/SkiaSharp.Views.Uno/SkiaSharp.Views.Uno.Wasm/WasmScripts/SkiaSharp.Views.Uno.Wasm.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add the GPU views for the Uno Platform.
Bugs Fixed
API Changes
Adding
SKSwapChainPanelto Uno PlatformBehavioral Changes
New views.
PR Checklist