Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(resolve conflict in dbichko's fork) set debian repository based on major version only #8

Merged
merged 1 commit into from
Jun 9, 2017

Conversation

nerab
Copy link
Collaborator

@nerab nerab commented Mar 27, 2017

I cherry-picked the commit by @dbichko (crediting him as author) and fixed the conflict. I hope this helps move the PR forward.

This is the text from the original commit:

Only update apt-cache when needed

Instead of always updating the apt cache, leverage the 'update_cache'
method during the apt install task. Prior to this patch, every run of
this role resulted in a "changed" state. This patch will clean up that
report to only be "changed" when this actually did indeed change (as
updating the apt-cache isn't a meaningful "change").

use apt_repository instead of file copy

Only update apt-cache when needed

Instead of always updating the apt cache, leverage the 'update_cache'
method during the apt install task.  Prior to this patch, every run of
this role resulted in a "changed" state.  This patch will clean up that
report to only be "changed" when this actually did indeed change (as
updating the apt-cache isn't a meaningful "change").

use apt_repository instead of file copy
@mongrelion
Copy link
Owner

Jesus, I just realised that Github wasn't watching this repository so I didn't get notified for any of the pull requests from the past ;( epic fail.

I'm going to move all this forward.

My apologies!

@mongrelion mongrelion merged commit 7613427 into mongrelion:master Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants