set debian repository based on major version only #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @dbichko, спасибо за это пул рыкуэст!))) Could you please squash your commits? Then we can get this merged immediately. |
Only update apt-cache when needed Instead of always updating the apt cache, leverage the 'update_cache' method during the apt install task. Prior to this patch, every run of this role resulted in a "changed" state. This patch will clean up that report to only be "changed" when this actually did indeed change (as updating the apt-cache isn't a meaningful "change"). use apt_repository instead of file copy
|
there you go. |
|
Oops. The pull request has some merge conflicts. Can you fix that? |
|
Fixed the merge conflict on #8 Thanks for this PR and for the effort put on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian installation is failing on a current system because it's looking for 'repos/Debian-8.6' and only 'Debian-8.0' is provided.
Since debian repos only reference the major version (ie 'jessie'), using 'ansible_distribution_major_version' for the file name seems appropriate.