Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration from TravisCI to GitHub Actions #244

Merged
merged 12 commits into from
Nov 3, 2023

Conversation

skalibog
Copy link
Contributor

@skalibog skalibog commented Oct 31, 2023

I succesfully migrate to GHA.
With these items I have my doubts and need help to fix:

  • Update gemspec.
  • Changes in code. Remove deprecated functionality, nothing changed. IDK how correct create this PR.
  • Danger token. I was put into repo secrets and use in CI step.
    Any help in completing this PR would be appreciated.

@skalibog skalibog mentioned this pull request Oct 31, 2023
@skalibog skalibog force-pushed the feature/migrate-ci-to-gha branch from 46fc18c to 37438c3 Compare October 31, 2023 19:32
@skalibog skalibog marked this pull request as draft October 31, 2023 19:38
@skalibog skalibog force-pushed the feature/migrate-ci-to-gha branch from 5df7abb to eb349e1 Compare October 31, 2023 20:06
@skalibog skalibog force-pushed the feature/migrate-ci-to-gha branch from eb349e1 to d69b29b Compare October 31, 2023 20:06
@skalibog skalibog marked this pull request as ready for review October 31, 2023 20:13
@dblock
Copy link
Collaborator

dblock commented Nov 2, 2023

Pickup a danger token from https://github.com/mongoid/mongoid-locker/tree/master/.github/workflows, PRs don't have access to secrets.

@dblock
Copy link
Collaborator

dblock commented Nov 2, 2023

Do you have a passing CI on your fork? Post link. Add a badge to README. Thanks!

@skalibog skalibog force-pushed the feature/migrate-ci-to-gha branch 2 times, most recently from a9a0719 to 51929a6 Compare November 2, 2023 08:48
@skalibog skalibog force-pushed the feature/migrate-ci-to-gha branch from 51929a6 to ff1cdaa Compare November 2, 2023 08:50
@skalibog
Copy link
Contributor Author

skalibog commented Nov 2, 2023

@dblock Hey, yes all passing well.
Here is the following links:
Actions: https://github.com/skalibog/mongoid-rspec/actions
README: https://github.com/skalibog/mongoid-rspec/tree/feature/migrate-ci-to-gha
Badges not working well, cause it is references to mongoid/mongoid-rspec without GHA. After merge all will be good.
And I added a rubocop badge.

@dblock dblock merged commit 8bb0c65 into mongoid:master Nov 3, 2023
@dblock
Copy link
Collaborator

dblock commented Nov 3, 2023

Thanks for doing this! There are other projects in the mongoid org that could use the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants