Skip to content

Commit

Permalink
Danger changes, ci fixes, and more
Browse files Browse the repository at this point in the history
  • Loading branch information
skalibog committed Oct 31, 2023
1 parent a8b3e39 commit 46fc18c
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 15 deletions.
9 changes: 5 additions & 4 deletions .github/workflows/danger.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
name: PR Linter

on: [push]
on: [pull_request]

jobs:
danger:
runs-on: ubuntu-latest
# if: github.event_name == 'pull_request' # if only run pull request when multiple trigger workflow
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
- uses: ruby/setup-ruby@v1
with:
ruby-version: '3.2.2'
- uses: actions/cache@v3
with:
path: vendor/bundle
key: ${{ runner.os }}-gems-${{ hashFiles('Gemfile') }}
key: ${{ runner.os }}-gems-${{ hashFiles('Gemfile') }} # change your gemfile path
restore-keys: |
${{ runner.os }}-gems-
- uses: MeilCli/danger-action@v5
Expand All @@ -23,4 +24,4 @@ jobs:
danger_file: 'Dangerfile'
danger_id: 'danger-pr'
env:
DANGER_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DANGER_GITHUB_API_TOKEN: ${{ secrets.DANGER_API_TOKEN }}
6 changes: 3 additions & 3 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ jobs:
entry:
- { ruby: '2.6', mongodb: '4.4', gemfile: 'mongoid-4.0', bundler: '1.17.3' }
- { ruby: '2.7', mongodb: '4.4', gemfile: 'mongoid-5.0', bundler: '1.17.3' }
- { ruby: '2.7', mongodb: '4.4', gemfile: 'mongoid-6.0' }
- { ruby: '2.7', mongodb: '4.4', gemfile: 'mongoid-7.0' }
- { ruby: '2.7', mongodb: '4.4', gemfile: 'mongoid-6.0', bundler: '2.4.19' }
- { ruby: '2.7', mongodb: '4.4', gemfile: 'mongoid-7.0', bundler: '2.4.19' }
- { ruby: '2.7', mongodb: '4.4', gemfile: 'mongoid-8.0', bundler: '2.4.19' }
- { ruby: '3.0', mongodb: '4.4', gemfile: 'mongoid-8.0', bundler: '2.4.19' }
- { ruby: '3.1', mongodb: '4.4', gemfile: 'mongoid-8.0', bundler: '2.4.19' }
Expand All @@ -23,7 +23,7 @@ jobs:
uses: supercharge/[email protected]
with:
mongodb-version: ${{ matrix.entry.mongodb }}
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
Expand Down
1 change: 0 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ AllCops:
NewCops: enable
Exclude:
- vendor/**/*
- gemfiles/**/*
- bin/**/*
- data/**/*

Expand Down
4 changes: 1 addition & 3 deletions gemfiles/mongoid-4.0.gemfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# This file was generated by Appraisal

source 'https://rubygems.org'

gem 'mongoid', '~> 4.0.0'
gem 'rails', '~> 4.0'

gemspec path: '../'
gemspec path: '../'
2 changes: 1 addition & 1 deletion gemfiles/mongoid-5.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ gem 'mongoid', '~> 5.0.0'
gem 'rails', '~> 4.0'
gem 'bigdecimal', '~> 1.3'

gemspec path: '../'
gemspec path: '../'
2 changes: 0 additions & 2 deletions gemfiles/mongoid-6.0.gemfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# This file was generated by Appraisal

source 'https://rubygems.org'

gem 'mongoid', '~> 6.0.2'
Expand Down
2 changes: 1 addition & 1 deletion gemfiles/mongoid-8.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ source 'https://rubygems.org'
gem 'mongoid', '~> 8.0.0'
gem 'rails', '~> 7.0'

gemspec path: '../'
gemspec path: '../'

0 comments on commit 46fc18c

Please sign in to comment.