Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-188: fixed issue related with read non-existing resource #494

Merged
merged 1 commit into from
Jul 22, 2021
Merged

INTMDB-188: fixed issue related with read non-existing resource #494

merged 1 commit into from
Jul 22, 2021

Conversation

abner-dou
Copy link
Contributor

Description

Read methods fixed in resources, there was a bug when refreshing the state when the resource is removed from the outside terraform, but still in the configuration file
Related to TeamsUpdate - fixing small bug, again missing update

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@abner-dou abner-dou changed the title fixed issue related with read non-existent resource INTMDB-188: fixed issue related with read non-existent resource Jul 19, 2021
@abner-dou abner-dou changed the title INTMDB-188: fixed issue related with read non-existent resource INTMDB-188: fixed issue related with read non-existing resource Jul 19, 2021
themantissa
themantissa approved these changes Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

andreaangiolillo
andreaangiolillo approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mongodbatlas/resource_mongodbatlas_cloud_provider_access.go Show resolved Hide resolved
@abner-dou abner-dou merged commit 5a59aa0 into master Jul 22, 2021
@abner-dou abner-dou deleted the INTMDB-188-Update-existing-resources branch July 22, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@thetonymaster thetonymaster thetonymaster approved these changes

@themantissa themantissa themantissa approved these changes

@coderGo93 coderGo93 Awaiting requested review from coderGo93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abner-dou @themantissa @thetonymaster @andreaangiolillo