TeamsUpdate - fixing small bug, again missing update #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themantissa
approved these changes
Mar 1, 2021
Comment on lines
+1
to
+8
| # Global rule | ||
| * @themantissa | ||
|
|
||
| # examples | ||
| /examples/** @nikhil-mongo | ||
|
|
||
| # resources & datasources, provider | ||
| /mongodbatlas/** @coderGo93 @leofigy |
Comment on lines
+90
to
+95
| // new resource missing | ||
| reset := strings.Contains(err.Error(), "404") && !d.IsNewResource() | ||
| if reset { | ||
| d.SetId("") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
We've had a few of these. Should we perhaps do a ticket for an audit to check all resources or do as we've done, add as we find them?
There was a problem hiding this comment.
yea, agree with that :)
There was a problem hiding this comment.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing refreshing the state when the team is removed from the outside terraform, but still in the configuration file
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments