Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fixes linter cache #1555

Merged
merged 5 commits into from
Oct 24, 2023
Merged

feat: Fixes linter cache #1555

merged 5 commits into from
Oct 24, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Oct 24, 2023

Description

Jira ticket: INTMDB-1222

Disables linter cache as it generates more than 20,000 lines in the log. Also reduces time from 90s to 40s.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

@lantoli lantoli marked this pull request as ready for review October 24, 2023 11:57
@lantoli lantoli requested a review from a team as a code owner October 24, 2023 11:57
@lantoli lantoli changed the title feat: Disables linter cache feat: Fixes linter cache Oct 24, 2023
Co-authored-by: Gustavo Bazan <[email protected]>
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 12%
Summary 3% (271 / 10296)

@lantoli lantoli requested a review from gssbzn October 24, 2023 12:11
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@lantoli lantoli merged commit 62b84a6 into master Oct 24, 2023
19 checks passed
@lantoli lantoli deleted the INTMDB-1222_cache_lint branch October 24, 2023 12:19
@andreaangiolillo
Copy link
Collaborator

Did we open a similar PR for other integrations? Thanks! : )

@lantoli
Copy link
Member Author

lantoli commented Nov 2, 2023

Did we open a similar PR for other integrations? Thanks! : )

@andreaangiolillo we did for CLI: mongodb/mongodb-atlas-cli#2395

we didn't do it in CFN, please review, thx! mongodb/mongodbatlas-cloudformation-resources#803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants