Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter cache #2395

Merged
merged 1 commit into from
Oct 24, 2023
Merged

chore: Fix linter cache #2395

merged 1 commit into from
Oct 24, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Oct 24, 2023

Proposed changes

Fix linter cache by disabling Go cache as it's duplicated and not needed. It helps to reduce errors logs in linter "prepare environment" step and reduce lint run duration.

same change as in: mongodb/terraform-provider-mongodbatlas#1555

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

Example of previous errors:

Screenshot 2023-10-24 at 14 35 44

@lantoli lantoli marked this pull request as ready for review October 24, 2023 12:39
@lantoli lantoli requested a review from a team October 24, 2023 12:39
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@lantoli lantoli merged commit 200f5df into master Oct 24, 2023
12 checks passed
@lantoli lantoli deleted the linter_cache branch October 24, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants