Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix so cleanup-test-env script continues if delete of one project fails #1516

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

AgustinBettati
Copy link
Member

@AgustinBettati AgustinBettati commented Oct 10, 2023

Description

Jira ticket: INTMDB-1123

Looking into the history of this ticket, I see that core idea is to properly handle deletion of projects that have existing clusters or private endpoints while also having unified code with other integrations. We can include this fix but as something temporary to cleanup the majority of empty project we currently have (which will ublock PRs). Would not consider the jira ticket as finished.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.

Further comments

Example execution running locally showing failed delete and script continues:
Screenshot 2023-10-10 at 10 07 44

@AgustinBettati AgustinBettati requested a review from a team as a code owner October 10, 2023 08:17
@github-actions
Copy link
Contributor

Code Coverage

Package Line Rate Health
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas 2%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/framework/validator 68%
github.com/mongodb/terraform-provider-mongodbatlas/mongodbatlas/util 20%
Summary 3% (271 / 10281)

Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Make sure to update the related action in CFN. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants