Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix so cleanup-test-env script continues if delete of one project fails #775

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

AgustinBettati
Copy link
Member

Proposed changes

Jira ticket: INTMDB-1123

Maintain consistency with mongodb/terraform-provider-mongodbatlas#1516

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Manual QA performed:

  • cfn invoke for each of CRUDL/cfn test
  • Updated resource in example
  • Published to AWS private registry
  • Used the template in example to create and update a stack in AWS
  • Deleted stack to ensure resources are deleted
  • Created multiple resources in same stack
  • Validated in Atlas UI
  • Included screenshots

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • For CFN Resources: I have released by changes in the private registry and proved by change
    works in Atlas

Further comments

@AgustinBettati AgustinBettati requested a review from a team as a code owner October 10, 2023 08:56
@AgustinBettati AgustinBettati added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit 442a9f1 Oct 10, 2023
24 checks passed
@AgustinBettati AgustinBettati deleted the INTMDB-1123 branch October 10, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants