-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Update 1.12.0 release guide and Changelog #1488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @maastha! Made an additional commit and one suggestion. Also suggest let's wait to hear back from NTSE in case of any additional feedback before releasing v1.12.1. If nothing by tomorrow your time feel free to release.
Co-authored-by: Zuhair Ahmed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maastha LGTM % a few style tweaks + moving Breaking Changes earlier in that item
CHANGELOG.md
Outdated
@@ -11,10 +11,10 @@ | |||
|
|||
**Bug Fixes** | |||
|
|||
- Fix when removing `collectionName` from user role [\#1471](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1471) [Breaking Change] ([marcosuma](https://github.com/marcosuma)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think breaking change
should be the first thing in this item. I think we should also bold this text to make it stand out. Also a minor wording tweak to make the structure of this item align with the others.
- Fix when removing `collectionName` from user role [\#1471](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1471) [Breaking Change] ([marcosuma](https://github.com/marcosuma)) | |
- **Breaking Change**: Fixes an issue where removing `collectionName` from user role didn't work [\#1471](https://github.com/mongodb/terraform-provider-mongodbatlas/pull/1471) ([marcosuma](https://github.com/marcosuma)) |
Co-authored-by: John Williams <[email protected]>
Description
This PR updates the Changelog and release guide for v1.12.0 of the provider to include guidance for this fix #1471
Link to any related issue(s):
Type of change:
Required Checklist:
Further comments