Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove collectionName from user role doesn't work #1471

Merged
merged 3 commits into from
Sep 15, 2023
Merged

fix: remove collectionName from user role doesn't work #1471

merged 3 commits into from
Sep 15, 2023

Conversation

marcosuma
Copy link
Collaborator

@marcosuma marcosuma commented Sep 13, 2023 •
edited by gssbzn
Loading

Description

Please include a summary of the fix/feature/change, including any relevant motivation and context.

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1062
Closes #1462

All details and investigation is written in the related issue.

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@marcosuma marcosuma requested a review from a team as a code owner September 13, 2023 09:50
andreaangiolillo
andreaangiolillo approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcosuma marcosuma merged commit d132a64 into master Sep 15, 2023
19 checks passed
@marcosuma marcosuma deleted the INTMDB-1062-fix-collection_name-roles branch September 15, 2023 06:50
@marcosuma marcosuma added the bug label Sep 15, 2023
This was referenced Sep 20, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgustinBettati AgustinBettati AgustinBettati approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

@gssbzn gssbzn gssbzn approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing DB user role from [email protected] to readwrite@DB doesn't work
4 participants
@marcosuma @gssbzn @andreaangiolillo @AgustinBettati