-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: removed 1.12.0 deprecated fields. #1418
refactor: removed 1.12.0 deprecated fields. #1418
Conversation
…015-remove-deprecated-params-1.12.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update the documentation as well: https://github.com/mongodb/terraform-provider-mongodbatlas/tree/master/website/docs
r = resources and d = data sources
mongodbatlas/resource_mongodbatlas_cloud_provider_access_setup_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes LGTM after reverting the removed acceptance tests.
Great work here 💯 !
One last action to do as part of this ticket is to add a list of deprecated fields per resource/datasource in the PR description (or in the JIRA ticket) to help us add this info in the CHANGELOG before the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing the test change. Would look into Andreas last comment before merging.
22aeae9
into
CLOUDP-189585-plugin-framework-migration
Description
Removing all the fields that have been declared as to be deprecated in v1.12.0.
Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-1015
Type of change:
Required Checklist:
Further comments