Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change to drop deprecated fields made in minor version release #1493

Closed
TGNThump opened this issue Sep 22, 2023 · 3 comments
Closed
Labels

Comments

@TGNThump
Copy link

TGNThump commented Sep 22, 2023

PR #1418, which was tagged with breaking-change was released in a minor version bump, breaking backwards compatibility.

As a result, our terraform runs are failing with:

│ Error: Unsupported attribute
│ This object does not have an attribute named "aws_private_link_srv".
@github-actions
Copy link
Contributor

Thanks for opening this issue. The ticket INTMDB-1137 was created for internal tracking.

@TGNThump TGNThump changed the title Breaking change made in minor version release Breaking change to deprecated fields made in minor version release Sep 22, 2023
@TGNThump TGNThump changed the title Breaking change to deprecated fields made in minor version release Breaking change to drop deprecated fields made in minor version release Sep 22, 2023
@Zuhairahmed
Copy link
Collaborator

Zuhairahmed commented Sep 27, 2023

hi @TGNThump, we apologize for the friction that this has caused you and your team. as of late, our versioning scheme has become an increasing focus for us internally and we may have changes to our approach in the near future to provide our users more visibility, clarity, and consistency with other terraform providers.

with that said, we currently follow a non-standard semantic versioning approach where instead of MAJOR.MINOR.PATCH, we use a 0.Major.Minor approach. so for us, v1.12.0 release we considered a major release with potential to have breaking changes (though we do try to limit breaking changes as much as possible) and our latest version v1.12.1 would be considered a minor release which we are guaranteeing not to have any breaking changes.

we plan to release documentation and additional guidance here as mentioned once we have aligned on best long term approach for our users. in the interim, would love to hear your feedback @TGNThump in case you have anything else to share? again appreciate your patience and understanding here until we get there.

@Zuhairahmed Zuhairahmed added the not_stale Not stale issue or PR label Sep 27, 2023
@Zuhairahmed Zuhairahmed added stale and removed not_stale Not stale issue or PR labels Nov 9, 2023
@Zuhairahmed
Copy link
Collaborator

Resolving issue, if there is anything else you need feel free to create a new issue. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants