Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTMDB-767: Update TF docs to lower case for frequency types #1131

Merged
merged 3 commits into from
Apr 19, 2023
Merged

INTMDB-767: Update TF docs to lower case for frequency types #1131

merged 3 commits into from
Apr 19, 2023

Conversation

Zuhairahmed
Copy link
Contributor

@Zuhairahmed Zuhairahmed commented Apr 19, 2023 •
edited
Loading

Description

Update TF docs to lower case for frequency types

Link to any related issue(s): https://jira.mongodb.org/browse/INTMDB-767

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@Zuhairahmed Zuhairahmed requested a review from a team as a code owner April 19, 2023 05:14
martinstibbe
martinstibbe reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@martinstibbe martinstibbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maastha
maastha approved these changes Apr 19, 2023
View reviewed changes
Copy link
Collaborator

@maastha maastha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zuhairahmed Zuhairahmed merged commit 6c2abca into release-staging-v.1.9.0 Apr 19, 2023
martinstibbe added a commit that referenced this pull request Apr 27, 2023
@martinstibbe @Zuhairahmed
@jwilliams-mongo @zach-carr
Release staging v.1.9.0 (#1143)
30ede80 
* INTMDB-767: Update TF docs to lower case for frequency types (#1131)

* Update cloud_backup_schedule.html.markdown

* Update cloud_backup_schedule.html.markdown

* Update resource_mongodbatlas_cloud_backup_schedule_test.go

* Removing disk_size_gb examples (#1133)

* removing disk_size_gb examples

Since we have stopped including this optional disk_size_gb parameter in current cluster examples, went back to clean up previous examples as well

* Delete main.tf

* Create main.tf

* Update main.tf

* Update main.tf

* Update main.tf

* Update main.tf

* Update main.tf

* Update main.tf

* Update atlas_cluster.tf

* Update atlas.tf

* Update cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* Update atlas-cluster.tf

* DOCSP-28948: addressing user feedback on search index resource docs (#1137)

* INTMDB-587: New Feature: Backup Compliance Policy Support (#1127)

* Add support for mongodbatlas_backup_compliance_policy

* Update SDK

* Preliminary Documentation

* Add tests for BackupCompliancePolicy

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update mongodbatlas/resource_mongodbatlas_backup_compliance_policy.go

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: Zuhair Ahmed <[email protected]>

* Update Email

* Trim line length

* Update SDK

* doc updates to related resources

* Update website/docs/r/advanced_cluster.html.markdown

* Update website/docs/r/advanced_cluster.html.markdown

* Update website/docs/r/advanced_cluster.html.markdown

* Update website/docs/r/backup_compliance_policy.html.markdown

* Update website/docs/r/cloud_backup_schedule.html.markdown

* Update website/docs/r/cloud_backup_snapshot.html.markdown

* Update website/docs/r/cluster.html.markdown

* Update website/docs/r/project.html.markdown

* Update website/docs/r/backup_compliance_policy.html.markdown

* Update website/docs/d/backup_compliance_policy.html.markdown

* Update website/docs/r/backup_compliance_policy.html.markdown

* cluster termination note

* Restructure parameters

* Remove unused expandScheduledPolicyItems Update Docs tests

* Update examples

* Update docs with requested changes

* Update docs

* Remove reference_minute_of_hour parameter not used in backup policy

* Update backup_compliance_policy.html.markdown

* Update backup_compliance_policy.html.markdown

* Docs updates

* Lowercase lint error

* Update website/docs/r/backup_compliance_policy.html.markdown

* Update website/docs/r/cluster.html.markdown

* Update website/docs/r/backup_compliance_policy.html.markdown

* Update website/docs/r/backup_compliance_policy.html.markdown

* Update website/docs/r/advanced_cluster.html.markdown

* Update website/docs/r/cloud_backup_schedule.html.markdown

* Update website/docs/r/cloud_backup_snapshot.html.markdown

* Update website/docs/r/advanced_cluster.html.markdown

* Update website/docs/r/cloud_backup_snapshot.html.markdown

* Update website/docs/r/cluster.html.markdown

* Update website/docs/r/project.html.markdown

* Update website/docs/d/backup_compliance_policy.html.markdown

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/d/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/advanced_cluster.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/advanced_cluster.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/advanced_cluster.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/cluster.html.markdown

* Update website/docs/r/cloud_backup_snapshot.html.markdown

* Update website/docs/r/cloud_backup_schedule.html.markdown

* Update mongodbatlas/resource_mongodbatlas_backup_compliance_policy_test.go

Co-authored-by: zach-carr <[email protected]>

* Update website/docs/r/backup_compliance_policy.html.markdown

* Update website/docs/r/backup_compliance_policy.html.markdown

---------

Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: zach-carr <[email protected]>

* Update resource_mongodbatlas_project.go to detect null boolean values (#1145)

* Update resource_mongodbatlas_project.go

* Update resource_mongodbatlas_project.go

* Update resource_mongodbatlas_project.go

---------

Co-authored-by: Zuhair Ahmed <[email protected]>
Co-authored-by: John Williams <[email protected]>
Co-authored-by: zach-carr <[email protected]>
@Zuhairahmed Zuhairahmed deleted the INTMDB-767-1 branch June 15, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinstibbe martinstibbe martinstibbe left review comments

@maastha maastha maastha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zuhairahmed @martinstibbe @maastha