INTMDB-587: New Feature: Backup Compliance Policy Support #1127

martinstibbe · 2023-04-14T18:37:43Z

Description

New Feature: Backup Compliance Policy Support

Link to any related issue(s):

Type of change:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update
Documentation fix/enhancement

Required Checklist:

I have signed the MongoDB CLA
I have read the contribution guidelines
I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
I have added any necessary documentation (if appropriate)
I have run make fmt and formatted my code

Further comments

Zuhairahmed

few suggestions, can you ping me when updated and will take another spin. Thanks again @martinstibbe!

mongodbatlas/resource_mongodbatlas_backup_compliance_policy.go

mongodbatlas/data_source_mongodbatlas_backup_compliance_policy.go

mongodbatlas/resource_mongodbatlas_backup_compliance_policy.go

website/docs/d/backup_compliance_policy.html.markdown

website/docs/r/backup_compliance_policy.html.markdown

Zuhairahmed · 2023-04-17T04:43:56Z

just FYI @themantissa after this PR has been merged we can test each of the below error cases with pre-release binaries and will shares results:

Modify a backup policy for an individual cluster below the minimum requirements set in the Backup Compliance Policy = should result in an error from the API
Delete a backup snapshot. = should result in an error from the API
Decrease the retention time for a snapshot after it's taken.= should result in an error from the API
Disable Cloud Backup. = should result in an error from the API
Disable Continuous Cloud Backup if the Backup Compliance Policy has the Require Point in Time Restore to all clusters option set to On
Reduce the Continuous Cloud Backup Restore Window = should result in an error from the API
Delete the project if any snapshots exist = should result in an error from the API

Co-authored-by: Zuhair Ahmed <[email protected]>

maastha

We have released v0.25.0 for Atlas Go client. Will there be a follow-up PR to update that?

martinstibbe · 2023-04-18T14:09:25Z

We have released v0.25.0 for Atlas Go client. Will there be a follow-up PR to update that?

Added to PR reference to v0.25.0

maastha

LGTM

website/docs/r/advanced_cluster.html.markdown

Zuhairahmed · 2023-04-26T00:24:05Z

Approving to avoid blocking - those are all my comments! Happy to do another pass if you want one though.

Thanks again @zach-carr, committed all your other suggestions.

Co-authored-by: zach-carr <[email protected]>

website/docs/r/cluster.html.markdown

website/docs/r/cloud_backup_snapshot.html.markdown

website/docs/r/cloud_backup_schedule.html.markdown

…st.go Co-authored-by: zach-carr <[email protected]>

website/docs/r/backup_compliance_policy.html.markdown

* INTMDB-767: Update TF docs to lower case for frequency types (#1131) * Update cloud_backup_schedule.html.markdown * Update cloud_backup_schedule.html.markdown * Update resource_mongodbatlas_cloud_backup_schedule_test.go * Removing disk_size_gb examples (#1133) * removing disk_size_gb examples Since we have stopped including this optional disk_size_gb parameter in current cluster examples, went back to clean up previous examples as well * Delete main.tf * Create main.tf * Update main.tf * Update main.tf * Update main.tf * Update main.tf * Update main.tf * Update main.tf * Update atlas_cluster.tf * Update atlas.tf * Update cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * Update atlas-cluster.tf * DOCSP-28948: addressing user feedback on search index resource docs (#1137) * INTMDB-587: New Feature: Backup Compliance Policy Support (#1127) * Add support for mongodbatlas_backup_compliance_policy * Update SDK * Preliminary Documentation * Add tests for BackupCompliancePolicy * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update mongodbatlas/resource_mongodbatlas_backup_compliance_policy.go Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: Zuhair Ahmed <[email protected]> * Update Email * Trim line length * Update SDK * doc updates to related resources * Update website/docs/r/advanced_cluster.html.markdown * Update website/docs/r/advanced_cluster.html.markdown * Update website/docs/r/advanced_cluster.html.markdown * Update website/docs/r/backup_compliance_policy.html.markdown * Update website/docs/r/cloud_backup_schedule.html.markdown * Update website/docs/r/cloud_backup_snapshot.html.markdown * Update website/docs/r/cluster.html.markdown * Update website/docs/r/project.html.markdown * Update website/docs/r/backup_compliance_policy.html.markdown * Update website/docs/d/backup_compliance_policy.html.markdown * Update website/docs/r/backup_compliance_policy.html.markdown * cluster termination note * Restructure parameters * Remove unused expandScheduledPolicyItems Update Docs tests * Update examples * Update docs with requested changes * Update docs * Remove reference_minute_of_hour parameter not used in backup policy * Update backup_compliance_policy.html.markdown * Update backup_compliance_policy.html.markdown * Docs updates * Lowercase lint error * Update website/docs/r/backup_compliance_policy.html.markdown * Update website/docs/r/cluster.html.markdown * Update website/docs/r/backup_compliance_policy.html.markdown * Update website/docs/r/backup_compliance_policy.html.markdown * Update website/docs/r/advanced_cluster.html.markdown * Update website/docs/r/cloud_backup_schedule.html.markdown * Update website/docs/r/cloud_backup_snapshot.html.markdown * Update website/docs/r/advanced_cluster.html.markdown * Update website/docs/r/cloud_backup_snapshot.html.markdown * Update website/docs/r/cluster.html.markdown * Update website/docs/r/project.html.markdown * Update website/docs/d/backup_compliance_policy.html.markdown * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/d/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/advanced_cluster.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/advanced_cluster.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/advanced_cluster.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/cluster.html.markdown * Update website/docs/r/cloud_backup_snapshot.html.markdown * Update website/docs/r/cloud_backup_schedule.html.markdown * Update mongodbatlas/resource_mongodbatlas_backup_compliance_policy_test.go Co-authored-by: zach-carr <[email protected]> * Update website/docs/r/backup_compliance_policy.html.markdown * Update website/docs/r/backup_compliance_policy.html.markdown --------- Co-authored-by: Zuhair Ahmed <[email protected]> Co-authored-by: zach-carr <[email protected]> * Update resource_mongodbatlas_project.go to detect null boolean values (#1145) * Update resource_mongodbatlas_project.go * Update resource_mongodbatlas_project.go * Update resource_mongodbatlas_project.go --------- Co-authored-by: Zuhair Ahmed <[email protected]> Co-authored-by: John Williams <[email protected]> Co-authored-by: zach-carr <[email protected]>

martinstibbe added 3 commits April 13, 2023 21:07

Add support for mongodbatlas_backup_compliance_policy

20eaa3a

Update SDK

010e899

Preliminary Documentation

79af0ad

martinstibbe requested a review from a team as a code owner April 14, 2023 18:37

Zuhairahmed self-requested a review April 17, 2023 03:18

Zuhairahmed suggested changes Apr 17, 2023

View reviewed changes

Zuhairahmed requested a review from themantissa April 17, 2023 04:45

martinstibbe and others added 13 commits April 17, 2023 20:16

Add tests for BackupCompliancePolicy

8e381b6

Update website/docs/r/backup_compliance_policy.html.markdown

a193d85

Co-authored-by: Zuhair Ahmed <[email protected]>

Update mongodbatlas/resource_mongodbatlas_backup_compliance_policy.go

d8e9937

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

af24bad

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

bdad77a

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/r/backup_compliance_policy.html.markdown

0da8f52

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

d1dc2d5

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/r/backup_compliance_policy.html.markdown

ff3527e

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/r/backup_compliance_policy.html.markdown

c645010

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

b6cd7f0

Co-authored-by: Zuhair Ahmed <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

e67551b

Co-authored-by: Zuhair Ahmed <[email protected]>

Update Email

e4287dc

Trim line length

ac1aaa9

martinstibbe requested a review from Zuhairahmed April 18, 2023 02:54

maastha reviewed Apr 18, 2023

View reviewed changes

Update SDK

18934db

martinstibbe requested a review from maastha April 18, 2023 14:09

maastha approved these changes Apr 18, 2023

View reviewed changes

doc updates to related resources

1e8e619

Zuhairahmed reviewed Apr 18, 2023

View reviewed changes

website/docs/r/advanced_cluster.html.markdown Outdated Show resolved Hide resolved

Update website/docs/r/advanced_cluster.html.markdown

b2f53f4

Zuhairahmed added 5 commits April 25, 2023 20:15

Update website/docs/r/advanced_cluster.html.markdown

58ab1c4

Update website/docs/r/cloud_backup_snapshot.html.markdown

3703ee1

Update website/docs/r/cluster.html.markdown

e69cccd

Update website/docs/r/project.html.markdown

21bc1ee

Update website/docs/d/backup_compliance_policy.html.markdown

0462b69

Zuhairahmed and others added 10 commits April 25, 2023 20:25

Update website/docs/d/backup_compliance_policy.html.markdown

c9c3ba2

Co-authored-by: zach-carr <[email protected]>

Update website/docs/r/backup_compliance_policy.html.markdown

248a15d

Co-authored-by: zach-carr <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

8a2109b

Co-authored-by: zach-carr <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

ddec5a3

Co-authored-by: zach-carr <[email protected]>

Update website/docs/d/backup_compliance_policy.html.markdown

b3b3f67

Co-authored-by: zach-carr <[email protected]>

Update website/docs/r/advanced_cluster.html.markdown

2682caf

Co-authored-by: zach-carr <[email protected]>

Update website/docs/r/advanced_cluster.html.markdown

08bbadd

Co-authored-by: zach-carr <[email protected]>

Update website/docs/r/advanced_cluster.html.markdown

cb88d34

Co-authored-by: zach-carr <[email protected]>

Update website/docs/r/backup_compliance_policy.html.markdown

29ac4aa

Co-authored-by: zach-carr <[email protected]>

Update website/docs/r/backup_compliance_policy.html.markdown

f532232

Co-authored-by: zach-carr <[email protected]>