CLOUDP-186801: disable depguard linter

[josvazg]

All Submissions:

• Have you signed our CLA?
• Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
• Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

[github-actions]

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/dfc0b166b5c8378712e76d4a369486295b106c91

[helderjs]

@josvazg We should not disable the depguard linter, but update golangci-lint in the project and adjust its config.

[josvazg]

@josvazg We should not disable the depguard linter, but update golangci-lint in the project and adjust its config.

This change is to make the development environment make lint behaviour match the current CI state.

What is the value of having development fail for something the CI is not checking yet?
We can enable it back on the same PR that fixes the config and would make the CI use depguard.

[helderjs]

@josvazg Why do you think CI is not checking it?
The latest depguard version has changed its default behavior, requiring to explicitly setting a config for it.
OpenPeeDeeP/depguard#55
OpenPeeDeeP/depguard#49

[josvazg]

It seemed so, because make lint in development fails with a lot of depguard failures. In any case, the point of this PR is to fix the development behavior by default, while the proper fix gets deployed to both dev and the CI.

[josvazg]

If I understood correctly, I could alternatively just drop this PR and instead keep on using the same linter version as the CI to have the same results.
I will be closing this then.
Thanks!