Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with information on Allow/Deny List functionality #55

Closed
dixonwille opened this issue Jun 6, 2023 · 4 comments
Closed
Labels
enhancement New feature or request
Milestone

Comments

@dixonwille
Copy link
Member

It is unclear what an empty allow and deny list do. README should reflect this.

@dixonwille dixonwille added the enhancement New feature or request label Jun 6, 2023
@ianlewis
Copy link

ianlewis commented Jun 8, 2023

Currently it seems with golangci-lint 1.53+ that an empty allow (e.g. no depguard config) means that nothing is allowed. Pretty sure that changed from 1.52 as we didn't encounter errors before.

@dixonwille
Copy link
Member Author

dixonwille commented Jun 8, 2023

#49

Yes the default behavior changed. Having no depguard config, but enabling it did absolutely nothing in depguard v1.

@maqdev
Copy link

maqdev commented Oct 18, 2023

Is there a way to allow everything by default, and only deny what's in deny list? Removing allow section doesn't help.

@dixonwille
Copy link
Member Author

#70

I believe this is what you are looking for. I still want to document it before merging it in.

@dixonwille dixonwille added this to the v2.2.0 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants