chore: cancel connection attempt when removing connection, update assert to expect in webview and connection controller tests #667

Anemy · 2024-01-17T17:57:49Z

Also removed some setTimeout usage in our tests so they're a bit quicker.

…d of timeouts

Anemy · 2024-01-18T18:45:09Z

Going to merge in, feel free to revert if anything comes up.

Anemy added 2 commits January 17, 2024 03:57

chore: assert to expect in webview controller

eba64dc

chore: use expect in connection controller tests, use promises instea…

94756b3

…d of timeouts

Anemy changed the title ~~chore: update assert to expect in webview and connection controller tests~~ chore: cancel connection attempt when removing connection, update assert to expect in webview and connection controller tests Jan 17, 2024

Anemy merged commit c6e7633 into main Jan 18, 2024
5 checks passed

Anemy deleted the assert-to-expect branch January 18, 2024 18:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: cancel connection attempt when removing connection, update assert to expect in webview and connection controller tests #667

chore: cancel connection attempt when removing connection, update assert to expect in webview and connection controller tests #667

Anemy commented Jan 17, 2024 •

edited

Loading

Anemy commented Jan 18, 2024

chore: cancel connection attempt when removing connection, update assert to expect in webview and connection controller tests #667

chore: cancel connection attempt when removing connection, update assert to expect in webview and connection controller tests #667

Conversation

Anemy commented Jan 17, 2024 • edited Loading

Anemy commented Jan 18, 2024

Anemy commented Jan 17, 2024 •

edited

Loading