Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save documents from tree view and do not reopen them for playground runs VSCODE-399, VSCODE-400 #504

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix: save documents from tree view and do not reopen them for playground runs VSCODE-399, VSCODE-400 #504

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23e3694
fix: save documents from tree view and do not reopen them for playgro…
alenakhineika Mar 30, 2023
ace5df2
refactor: save mongodb document when resource scheme is mongodb docum…
alenakhineika Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@
"command": "mdb.saveMongoDBDocument",
"key": "ctrl+s",
"mac": "cmd+s",
"when": "mdb.isPlayground == true"
"when": "editorLangId == json"
alenakhineika marked this conversation as resolved.
Show resolved Hide resolved
}
],
"capabilities": {
Expand Down
2 changes: 0 additions & 2 deletions src/editors/playgroundController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -581,8 +581,6 @@ export default class PlaygroundController {

this._playgroundResult = evaluateResponse.result;

this._explorerController.refresh();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This triggers the click event on the selected in the tree view document. We do not refresh lists on the fly on other explorers, so let's also use the existing refresh button in this case.


await this._openPlaygroundResult();

return true;
Expand Down