fix: save documents from tree view and do not reopen them for playground runs VSCODE-399, VSCODE-400 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alenakhineika
commented
Mar 30, 2023
| @@ -581,8 +581,6 @@ export default class PlaygroundController { | |||
|
|
|||
| this._playgroundResult = evaluateResponse.result; | |||
|
|
|||
| this._explorerController.refresh(); | |||
There was a problem hiding this comment.
This triggers the click event on the selected in the tree view document. We do not refresh lists on the fly on other explorers, so let's also use the existing refresh button in this case.
Anemy
reviewed
Mar 30, 2023
Anemy
approved these changes
Mar 30, 2023
Anemy
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug fixes for the release:
Checklist
Motivation and Context
Types of changes