Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend completions VSCODE-376, VSCODE-381, VSCODE-389, VSCODE-390 #497

Merged
merged 9 commits into from
Mar 24, 2023
Merged

feat: extend completions VSCODE-376, VSCODE-381, VSCODE-389, VSCODE-390 #497

merged 9 commits into from
Mar 24, 2023

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Mar 23, 2023 •
edited
Loading

Description

  • VSCODE-376: Replace existing aggregation stage snippets with the MongoDB query API completion
  • VSCODE-389: Provide collection name completion in bracket notation
  • VSCODE-378: Support getCollection names completion
  • VSCODE-381: Fix field completion for collections specified using bracket notation

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Dependents

Dependent on: mongodb-js/devtools-shared#51
Implements: #417

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@alenakhineika alenakhineika marked this pull request as ready for review March 23, 2023 14:16
@alenakhineika
refactor: clean up
9b67e26
@alenakhineika
Merge remote-tracking branch 'origin/main' into extend-completions
dacca96 
# Conflicts:
#	src/test/suite/snippets/stageAutocompleter.test.ts
gribnoysup
gribnoysup approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disclaimer that I was mostly looking on changes around usage of getFilteredCompletions, looks good

@alenakhineika alenakhineika merged commit 0a27eea into main Mar 24, 2023
@alenakhineika alenakhineika deleted the extend-completions branch March 24, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gribnoysup gribnoysup gribnoysup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alenakhineika @gribnoysup