Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mongodb-constants): add filter method #51

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Conversation

gribnoysup
Copy link
Collaborator

Extracting this from compass, as we want to use this in vscode too. One difference with compass implementation is that I removed the prefix filtering prop as this logic is not used by vscode and codemirror autocompleters, so it's only relevant for ace editor that we are planning to remove anyway

Copy link
Collaborator

@alenakhineika alenakhineika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried and love it :) 🚀

@gribnoysup gribnoysup merged commit 2d6faa9 into main Mar 23, 2023
@gribnoysup gribnoysup deleted the filter-constants-helper branch March 23, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants