-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export to language actions appear for regular playground results VSCODE-334 #434
Merged
alenakhineika
merged 12 commits into
main
from
VSCODE-334-no-export-to-language-actions-in-plain-results
Sep 6, 2022
Merged
fix: export to language actions appear for regular playground results VSCODE-334 #434
alenakhineika
merged 12 commits into
main
from
VSCODE-334-no-export-to-language-actions-in-plain-results
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
reviewed
Aug 31, 2022
Anemy
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Nice. Left one suggestion on the test setting we can probably remove.
…tore the connection
Anemy
approved these changes
Sep 6, 2022
alenakhineika
deleted the
VSCODE-334-no-export-to-language-actions-in-plain-results
branch
September 6, 2022 19:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
./src/test/suite/index.ts
causes some kind of race condition and vscode rejetcs operation with therejected promise not handled within 1 second: Error: Unable to write to Workspace Settings because mdb.connectionSaving.hideOptionToChooseWhereToSaveNewConnections is not a registered configuration.
error for recent versions of vscode. Moved the following part to the./src/test/suite/connectionController.test.ts
before hook and looks like the error has gone. Let's keep an eye on it.Checklist
Motivation and Context
Types of changes