Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export to language actions appear for regular playground results VSCODE-334 #434

Merged

Conversation

alenakhineika
Copy link
Contributor

@alenakhineika alenakhineika commented Aug 31, 2022

Description

  • Remove export to language code lenses for regular playground results.
  • Seems that setting configurations in the ./src/test/suite/index.ts causes some kind of race condition and vscode rejetcs operation with the rejected promise not handled within 1 second: Error: Unable to write to Workspace Settings because mdb.connectionSaving.hideOptionToChooseWhereToSaveNewConnections is not a registered configuration. error for recent versions of vscode. Moved the following part to the ./src/test/suite/connectionController.test.ts before hook and looks like the error has gone. Let's keep an eye on it.
const connectionSaving = vscode.workspace.getConfiguration('mdb.connectionSaving');
await connectionSaving.update(
  'hideOptionToChooseWhereToSaveNewConnections',
  true,
  vscode.ConfigurationTarget.Global
);

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

package.json Outdated Show resolved Hide resolved
@alenakhineika alenakhineika requested a review from Anemy September 1, 2022 19:17
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice. Left one suggestion on the test setting we can probably remove.

src/test/suite/connectionController.test.ts Outdated Show resolved Hide resolved
@alenakhineika alenakhineika merged commit 2f43db1 into main Sep 6, 2022
@alenakhineika alenakhineika deleted the VSCODE-334-no-export-to-language-actions-in-plain-results branch September 6, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants