fix: export to language actions appear for regular playground results V…

…SCODE-334 (#434) * fix: export to language actions appear for regular playground results VSCODE-334 * test: try without disabling extensions * test: return disable extensions arg * refactor: fix spaces in package.json * refactor: remove metadata * test: try to set setting in tests * test: try other settings format * fix: write settings to global * test: try to disable from connection controller * test: trigger ci again to check * test: remove disabling the dialogue for prompting the user where to store the connection
mongodb-js · Sep 6, 2022 · 2f43db1 · 2f43db1
1 parent f145c89
commit 2f43db1
Show file tree

Hide file tree

Showing 5 changed files with 200 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/editors/exportToLanguageCodeLensProvider.ts b/src/editors/exportToLanguageCodeLensProvider.ts
@@ -45,6 +45,10 @@ export default class ExportToLanguageCodeLensProvider
     const buildersCodeLens = this.createCodeLens();
     const exportToLanguageCodeLenses: vscode.CodeLens[] = [];
 
+    if (['json', 'plaintext'].includes(this._exportToLanguageAddons.language)) {
+      return [];
+    }
+
     importStatementsCodeLens.command = {
       title: this._exportToLanguageAddons.importStatements
         ? 'Exclude Import Statements'

diff --git a/src/editors/playgroundController.ts b/src/editors/playgroundController.ts
@@ -397,6 +397,11 @@ export default class PlaygroundController {
         this._playgroundResultTextDocument,
         language
       );
+
+      this._exportToLanguageCodeLensProvider.refresh({
+        ...this._exportToLanguageCodeLensProvider._exportToLanguageAddons,
+        language,
+      });
     }
   }
 

diff --git a/src/test/suite/editors/exportToLanguageCodeLensProvider.test.ts b/src/test/suite/editors/exportToLanguageCodeLensProvider.test.ts
@@ -120,4 +120,30 @@ suite('Export To Language Code Lens Provider Test Suite', function () {
 
     expect(codeLenses.length).to.be.equal(2);
   });
+
+  test('does not render code lenses for json text', () => {
+    testExportToLanguageCodeLensProvider.refresh({
+      ...defaults,
+      builders: true,
+      mode: ExportToLanguageMode.OTHER,
+      language: 'json',
+    });
+
+    const codeLenses = testExportToLanguageCodeLensProvider.provideCodeLenses();
+
+    expect(codeLenses.length).to.be.equal(0);
+  });
+
+  test('does not render code lenses for plain text text', () => {
+    testExportToLanguageCodeLensProvider.refresh({
+      ...defaults,
+      builders: true,
+      mode: ExportToLanguageMode.OTHER,
+      language: 'plaintext',
+    });
+
+    const codeLenses = testExportToLanguageCodeLensProvider.provideCodeLenses();
+
+    expect(codeLenses.length).to.be.equal(0);
+  });
 });
diff --git a/src/test/suite/index.ts b/src/test/suite/index.ts
@@ -1,6 +1,5 @@
 import Mocha from 'mocha';
 import glob from 'glob';
-import * as vscode from 'vscode';
 import path = require('path');
 import MDBExtensionController from '../../mdbExtensionController';
 import { ext } from '../../extensionConstants';
@@ -51,28 +50,22 @@ export async function run(): Promise<void> {
         // headless linux.
         ext.keytarModule = new KeytarStub();
 
-        // Disable the dialogue for prompting the user where to store the connection.
-        void vscode.workspace
-          .getConfiguration('mdb.connectionSaving')
-          .update('hideOptionToChooseWhereToSaveNewConnections', true)
-          .then(() => {
-            // Add files to the test suite.
-            files.forEach((f) => mocha.addFile(path.resolve(testsRoot, f)));
-            try {
-              // Run the mocha test.
-              mocha.run((failures) => {
-                if (failures > 0) {
-                  e(new Error(`${failures} tests failed.`));
-                } else {
-                  c();
-                }
-              });
-            } catch (mochaRunErr) {
-              console.error('Error running mocha tests:');
-              console.error(mochaRunErr);
-              e(mochaRunErr);
+        // Add files to the test suite.
+        files.forEach((f) => mocha.addFile(path.resolve(testsRoot, f)));
+        try {
+          // Run the mocha test.
+          mocha.run((failures) => {
+            if (failures > 0) {
+              e(new Error(`${failures} tests failed.`));
+            } else {
+              c();
             }
           });
+        } catch (mochaRunErr) {
+          console.error('Error running mocha tests:');
+          console.error(mochaRunErr);
+          e(mochaRunErr);
+        }
       }
     );
   });