Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: fix typos in code and readme #418

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented May 27, 2022

Description

Checklist

  • N/A New tests and/or benchmarks are included
  • N/A Documentation is changed or added

Motivation and Context

  • Mostly just fixes typos in the README that bothered me.
    • windows → Windows
    • Commmand → Command
    • MacOS → macOS
  • Fixes a typo in the pull request template.
    • dependancy → dependency
  • Removes a redundant line break in the README.
  • Removes redundant assignment to connections, it's never used after that line anyway?
  • СonnectionQuickPicks != ConnectionQuickPicks. I'm surprised the former is even a valid name in JavaScript. 🤔 It uses a Unicode character instead of an actual C.

I recommend you review the ConnectionQuickPicks yourself! 2 quick ways you can prove the difference though is:

  1. CTRL + F and search one of them, and you'll find only one side of the diff will get highlighted.
  2. If you do a comparison they won't match, or generate a hash from the two and it'll generate different results.
  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on that С symbol. Not sure how that made it in. Starting to take a look at your prs now, thanks for the contributions!

@Anemy Anemy merged commit 3137a12 into mongodb-js:main Jun 1, 2022
@SethFalco SethFalco deleted the chores branch May 26, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants