Skip to content

Commit

Permalink
chores: fix typos in code and readme (#418)
Browse files Browse the repository at this point in the history
* typo: replace unicode C with C

* chore: fix typos and remove redundant linebreak
  • Loading branch information
SethFalco authored Jun 1, 2022
1 parent 6357efa commit 3137a12
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it's updating a dependancy, link to the Pull Request that originally introduced the fix -->
<!--- If it's updating a dependency, link to the Pull Request that originally introduced the fix -->
- [ ] Bugfix
- [ ] New feature
- [ ] Dependency update
Expand Down
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ Select queries and aggregations within your Playground files and translate them

![Query Translator](resources/screenshots/query-translator.png)


### Document Editing

MongoDB for VS Code makes it extremely easy to make changes to documents in your collections. You can open documents in an editor tab, edit them and save the changes back to MongoDB.
Expand Down Expand Up @@ -114,7 +113,7 @@ npm run local-install

This will compile and package MongoDB for VS Code into a `.vsix` file and add the extension to your VS Code.

To install this locally on windows:
To install this locally on Windows:

```shell
npm install
Expand All @@ -126,7 +125,7 @@ This will compile and package MongoDB for VS Code into a `.vsix` file and add th

If you get an error because the `code` command is not found, you need to install it in your `$PATH`.

Open VS Code, launch the Commmand Palette (⌘+Shift+P on MacOS, Ctrl+Shift+P on Windows and Linux), type `code` and select "Install code command in \$PATH".
Open VS Code, launch the Command Palette (⌘+Shift+P on macOS, Ctrl+Shift+P on Windows and Linux), type `code` and select "Install code command in \$PATH".

## License

Expand Down
6 changes: 3 additions & 3 deletions src/connectionController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ interface ConnectionAttemptResult {
connectionErrorMessage: string;
}

interface СonnectionQuickPicks {
interface ConnectionQuickPicks {
label: string;
data: { type: NewConnectionType, connectionId?: string }
}
Expand Down Expand Up @@ -833,7 +833,7 @@ export default class ConnectionController {
this._disconnecting = disconnecting;
}

getСonnectionQuickPicks(): СonnectionQuickPicks[] {
getConnectionQuickPicks(): ConnectionQuickPicks[] {
if (!this._connections) {
return [
{
Expand Down Expand Up @@ -868,7 +868,7 @@ export default class ConnectionController {

async changeActiveConnection(): Promise<boolean> {
const selectedQuickPickItem = await vscode.window.showQuickPick(
this.getСonnectionQuickPicks(),
this.getConnectionQuickPicks(),
{
placeHolder: 'Select new connection...'
}
Expand Down
8 changes: 3 additions & 5 deletions src/test/suite/connectionController.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,7 @@ suite('Connection Controller Test Suite', function () {
assert.strictEqual(name, 'new connection name');
});

test('СonnectionQuickPicks workspace connections list is displayed in the alphanumerical case insensitive order', async () => {
test('ConnectionQuickPicks workspace connections list is displayed in the alphanumerical case insensitive order', async () => {
await vscode.workspace
.getConfiguration('mdb.connectionSaving')
.update(
Expand All @@ -556,7 +556,7 @@ suite('Connection Controller Test Suite', function () {

await testConnectionController.loadSavedConnections();

let connections = testConnectionController._connections;
const connections = testConnectionController._connections;
const connectionIds = Object.keys(connections);

assert.strictEqual(connectionIds.length, 2);
Expand All @@ -576,11 +576,9 @@ suite('Connection Controller Test Suite', function () {

await testConnectionController.loadSavedConnections();

connections = testConnectionController._connections;

assert.strictEqual(connectionIds.length, 2);

const connectionQuickPicks = testConnectionController.getСonnectionQuickPicks();
const connectionQuickPicks = testConnectionController.getConnectionQuickPicks();

assert.strictEqual(connectionQuickPicks.length, 3);
assert.strictEqual(connectionQuickPicks[0].label, 'Add new connection');
Expand Down

0 comments on commit 3137a12

Please sign in to comment.